Message-ID: <b6e4ae3f-a3ff-b118-43ce-a45d007ae2e9@ti.com>
Date:   Tue, 7 Mar 2023 11:55:11 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 4/6] gpio: pisosr: Use devm_gpiochip_add_data() to
 simplify remove path
Content-Language: en-US
To:     Andy Shevchenko <andy@kernel.org>
CC:     Peter Tyser <ptyser@xes-inc.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230307165432.25484-1-afd@ti.com>
 <20230307165432.25484-4-afd@ti.com> <ZAd35D4C96MP5Qrm@smile.fi.intel.com>
From:   Andrew Davis <afd@ti.com>
In-Reply-To: <ZAd35D4C96MP5Qrm@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/7/23 11:44 AM, Andy Shevchenko wrote:
> On Tue, Mar 07, 2023 at 10:54:30AM -0600, Andrew Davis wrote:
>> Use devm version of gpiochip add function to handle removal for us.
>>
>> While here update copyright and module author.
> 
> ...
> 
>> -	mutex_destroy(&gpio->lock);
> 
> You need to wrap this into devm.
> 

I was thinking that but it seems there is no such thing. Most drivers
just ignore unwinding mutex_init() since it doesn't allocate anything.

mutex_destroy() is a NOP unless you are doing DEBUG builds were
it sets a magic value to check for use-after-free issues.

Andrew