Message-ID: <932aebd3-c655-3266-1acb-e41e8cbfb771@intel.com>
Date:   Tue, 7 Mar 2023 09:55:28 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v2 08/16] iommu: define and export
 iommu_access_remote_vm()
Content-Language: en-US
To:     Baolu Lu <baolu.lu@linux.intel.com>, Vinod Koul <vkoul@kernel.org>,
        "Dave Jiang" <dave.jiang@intel.com>
CC:     <dmaengine@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Alistair Popple <apopple@nvidia.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Lorenzo Stoakes" <lstoakes@gmail.com>,
        Christoph Hellwig <hch@infradead.org>, <iommu@lists.linux.dev>
References: <20230306163138.587484-1-fenghua.yu@intel.com>
 <20230306163138.587484-9-fenghua.yu@intel.com>
 <f7b0cbef-3d7d-e5aa-1971-fe230d0c80e1@linux.intel.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <f7b0cbef-3d7d-e5aa-1971-fe230d0c80e1@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGxEbjZ0U1Q4UVhzMzFQc1RLSXdUYTBML0txYTBFbkJvai9PL3ljVGNHQWhu?=
 =?utf-8?B?aGVxd0x2MU1yYldkTW5MWUduaERnRnJPZ1ZrNmZpb1BFK1BMaGZzazM1dThx?=
 =?utf-8?B?bU80djl1UU14Tlk3eEVuMkFqTTJLUG1LRmh6cDF4U0ZaK2hIQ0MvSCtwTzZa?=
 =?utf-8?B?enJua3drZzFjUXQvWHlzRlJhdk5SWW8rTlFJa1FmMnBOdlhlYjFnTCtBRGpu?=
 =?utf-8?B?eUpzbXZQZk1aR0VPQk1sWDc4TFR0VFdIWlhwam93ZlBMc0VoYkY4WWxnWGJY?=
 =?utf-8?B?Q3YvZTVUWm9lOFkzY25RQUFhT1llRWxVbjJyclNvUjN2UUdMTHMrT2dObDFC?=
 =?utf-8?B?T2hjMm04a3lZd3FINTkvNkpwVnE5WTFPQkN4bVRFQzJ5MkJWLzFJK3VjTW5W?=
 =?utf-8?B?cS9oMGdMZFFoTFBtaTFWY2c2WkVDYnREcnY2bXR2WlZtbWU5bW1TdEJvUUZM?=
 =?utf-8?B?VlJwTWZLVEZDWW40SE5pZHBvT29oZVpRMGRNa25HNjhuRllpMi9jdWZJTGUz?=
 =?utf-8?B?Nndqdk1FM1FseVJ6em9FOEpGdU9UR2g2WFFTSFZoZDg5dWpLVHM5NWxpZGJz?=
 =?utf-8?B?aHJKY2IyaDNKZWhkQnU2NDU3ZUV3MVVxWmhoeW5kL1pSQ2JWbERXNGJNZTNq?=
 =?utf-8?B?WFBleUhCU1Q0M3c2a3F6d2JjT3V3MmN2bjBuM3d1WHo4VzBmOTFpZmhMa0ZS?=
 =?utf-8?B?ZjFxWVl0K29OL1VEdU9VRmFJcTlpRXJNYndqN3FWclRkRm5uK05hazVCM2tR?=
 =?utf-8?B?ZkR3TmRMcnNLSDFOS0dWbCtrSHpQM0oydEc5a01xcEJqVHlxclpjaWszUkhZ?=
 =?utf-8?B?VlhOcnVpSU82VnZXY293Rk5lRmRtRXZXdXBVOEM5U2VHU29DZitZREc2OEs0?=
 =?utf-8?B?RWxLQnZNSHZBSW9JYXFpbEpNSk5yOFpIYTF2eXRQMTdXSWpSbUpJdUJhVHRo?=
 =?utf-8?B?SEdsc2dPWlpFb2d5QVFYZVBOQ0NEaDhob2ZuaTJmOVpqZ1BPSmIwODlTVTlK?=
 =?utf-8?B?bjhncERHZThzYU1SaDlUdm5HQThpVTQ3WEhTU2czTlFoMWhQenJPd3NJOGFk?=
 =?utf-8?B?eWxzRGlzRzZuODZXMExWNE85ZkdaWWFMa1NPZExvdHg2eWdPMXExNkZjK1VH?=
 =?utf-8?B?cWFuL1gyN1BBblkyOUN6Nm0waGpPREk5MUxxK2NCZnA2dENNRTYyNHYwT0pV?=
 =?utf-8?B?Tk5rVEVGRHR0WmNaM29yUnM2U0hlcHdGSEE0MzZrN241dnJuQWZqbmk0NmI0?=
 =?utf-8?B?YnVlWmtHWTRlZ0Zxc3p6MnMvR09XVU9USVRJL1BWUUxYU2g3dFNOcVVYNWZJ?=
 =?utf-8?B?ZjF3bmpJbXRkZldhRk5Zb0hDNTFib0FxTUdWTWVsU2R6RG0zcERzWUR5SDFR?=
 =?utf-8?B?ekxwUmpqYyt2VmZrWmwxbHplQ3hvcUlSNXZBTWNObHVPcmw4UnV4eUE3aDl1?=
 =?utf-8?B?S3FmWmRtS0w2UWRrTGJmOUdNNWFmSlozY3BMandBQm1BMy9WQnJYTmtnOUlC?=
 =?utf-8?B?NHpFbDA0NTFISFhUVGZXT2t1Y2JodUdmWWtzb1kxVnoxdkVMZFVrSFJkVjA0?=
 =?utf-8?B?dkR5R2I2TGVEZGVmbkdzaXd1QVo4dzZlbXZrWDhrcnZ6bnBZNGo2eGd0TnRq?=
 =?utf-8?B?cGtjL2tRWENjLzM3d2FGMEZubjM5clBVb3g5U0k0a2I5YTFuR05yc2pHemRJ?=
 =?utf-8?B?WkZvRDdXbkYwY2hOdzExT0ZqbGVyRVpiUUFHa0QxbUhmN0VGaUFRbHZ2d2tt?=
 =?utf-8?B?ODBxSWNWaUwyR3FSTFFvTm84RmUwa0I2QmVIVDJPODdGNFFFYW9ycTlOWUND?=
 =?utf-8?B?WnM5YUZlMnZQanBsK0Z1RDJmZXZyeXFLRDhLaUJDaUFQSEFHZWc5TFR5OFB0?=
 =?utf-8?B?dlV4SmloYWFTWE1pQU5vcXJ3NVkwU1VGNnpZK1VXVG1tQk9GU1o5eXNuRDRt?=
 =?utf-8?B?Ykdvem04VHYzbk9HMTBISkZ2bEt5M2RZYmdTdmk3V0pZeHJoTUdhUGJHZ3BD?=
 =?utf-8?B?cXJJWlpOUVU1Sklva3lhWlBBbVJ3K1BMYklDcTRxTitjQmVJWmxjNTk1OS94?=
 =?utf-8?B?STlxZXhadERLWDlWL1VXQ2h3c3FMbDI1Rnp3ME1IdXZVUEE3SzFnaFFzS3Js?=
 =?utf-8?Q?nWDpvi4VXIgeDsnkD2pPj3CY9?=
X-MS-Exchange-CrossTenant-Network-Message-Id: afe10b97-b6d3-4554-d9a5-08db1f35256e
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 17:55:32.6681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6iSCX3zCDHJ9OsFomwPKNTdZp2lDWji/KxeuT+uZiDyHuIAi122401MI62pdFbhUaCUK6zVbzMB3V0osnyRWWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4538
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Baolu,

On 3/6/23 17:41, Baolu Lu wrote:
> On 3/7/23 12:31 AM, Fenghua Yu wrote:
>> Define and export iommu_access_remote_vm() to allow IOMMU related
>> drivers to access user address space by PASID.
>>
>> The IDXD driver would like to use it to write the user's completion
>> record that the hardware device is not able to write to due to user
>> page fault.
> 
> I don't quite follow here. Isn't I/O page fault already supported?

The following patch 9 in this series explains in details why IDXD device 
cannot use page fault to write to user memory: 
https://lore.kernel.org/dmaengine/20230306163138.587484-10-fenghua.yu@intel.com/

"DSA supports page fault handling through PRS. However, the DMA engine
that's processing the descriptor is blocked until the PRS response is
received. Other workqueues sharing the engine are also blocked.
Page fault handing by the driver with PRS disabled can be used to
mitigate the stalling.

With PRS disabled while ATS remain enabled, DSA handles page faults on
a completion record by reporting an event in the event log. In this
instance, the descriptor is completed and the event log contains the
completion record address and the contents of the completion record."

That's why IDXD driver needs this IOMMU's helper 
iommu_access_remote_vm() to copy the completion record from event log 
buffer to user space.

Thanks.

-Fenghua