Date:   Tue, 7 Mar 2023 18:44:35 +0000
From:   Conor Dooley <conor@kernel.org>
To:     Sunil V L <sunilvl@ventanamicro.com>
Cc:     linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Anup Patel <apatel@ventanamicro.com>,
        Andrew Jones <ajones@ventanamicro.com>,
        Atish Patra <atishp@rivosinc.com>,
        'Conor Dooley ' <conor.dooley@microchip.com>,
        llvm@lists.linux.dev
Subject: Re: [PATCH V3 00/20] Add basic ACPI support for RISC-V
Message-ID: <a9823561-2e32-49e8-b6c9-73e4b8f8cf8d@spud>
References: <20230303133647.845095-1-sunilvl@ventanamicro.com>
 <16007014-c5f2-4b07-baec-e19952236aa5@spud>
 <ZAbGSA6F0kfv9YYw@sunil-laptop>
 <E7FB4927-1FE6-435A-914E-9615C2AD9D34@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Syeh4y7IR+Jnz+iK"
Content-Disposition: inline
In-Reply-To: <E7FB4927-1FE6-435A-914E-9615C2AD9D34@kernel.org>
Precedence: bulk


--Syeh4y7IR+Jnz+iK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 07, 2023 at 06:13:22AM +0000, Conor Dooley wrote:
>=20
>=20
> On 7 March 2023 05:06:16 GMT, Sunil V L <sunilvl@ventanamicro.com> wrote:
> >On Mon, Mar 06, 2023 at 09:51:09PM +0000, Conor Dooley wrote:
> >> Hey Sunil,
> >>=20
> >> On Fri, Mar 03, 2023 at 07:06:27PM +0530, Sunil V L wrote:
> >> > This patch series enables the basic ACPI infrastructure for RISC-V.
> >> > Supporting external interrupt controllers is in progress and hence i=
t is
> >> > tested using poll based HVC SBI console and RAM disk.
> >> >=20
> >> > The first patch in this series is one of the patch from Jisheng's
> >> > series [1] which is not merged yet. This patch is required to support
> >> > ACPI since efi_init() which gets called before sbi_init() can enable
> >> > static branches and hits a panic.
> >> >=20
> >> > Patch 2 and 3 are ACPICA patches which are not merged into acpica yet
> >> > but a PR is raised already.
> >> >=20
> >> > Below are two ECRs approved by ASWG.
> >> > RINTC - https://drive.google.com/file/d/1R6k4MshhN3WTT-hwqAquu5nX6xS=
EqK2l/view
> >> > RHCT - https://drive.google.com/file/d/1nP3nFiH4jkPMp6COOxP6123DCZKR=
-tia/view
> >> >=20
> >> > The series depends on Anup's IPI improvement series [2].
> >> >=20
> >> > [1] https://lore.kernel.org/all/20220821140918.3613-1-jszhang@kernel=
=2Eorg/
> >> > [2] https://lore.kernel.org/lkml/20230103141221.772261-7-apatel@vent=
anamicro.com/T/
> >>=20
> >> Building a clang-15 allmodconfig (I didn't try gcc) with this series, =
and
> >> Anup's IPI bits, results in a broken build, due to failings in cmpxchg:
> >>=20
> >> /stuff/linux/drivers/platform/surface/aggregator/controller.c:61:25: e=
rror: call to __compiletime_assert_335 declared with 'error' attribute: BUI=
LD_BUG failed
> >>         while (unlikely((ret =3D cmpxchg(&c->value, old, new)) !=3D ol=
d)) {
> >>                                ^

> > I am able to build without any of these issues using clang-15. I am
> > wondering whether the base is proper. I had rebased on top of the master
> > and couple of patches from IPI series were already merged in the master.
> >=20
> > Do you mind verifying with my branch
> > https://github.com/vlsunil/linux/commits/acpi_b1_us_review_ipi17_V3?
>=20
> I can check that later I suppose.

That's broken too.

> > Or if you could provide me your branch details, I can look further.
>=20
> 6.3-rc1, with both series applied, sans Anups applied patches.

I've pushed my stuff here, but unlikely that it makes any odds since
your branch experiences the same build issue.
https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/ borked-acp=
i-surface

My build commands are wrapped in a script, but it's an LLVM=3D1
allmodconfig run w/ clang-15(.0.7) etc.

Chees,
Conor.

--Syeh4y7IR+Jnz+iK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZAeGEwAKCRB4tDGHoIJi
0pBJAQC6eUPL8agYJlDStZNq2bNTc9yH0rw+9QH9WnR5mdEIxwD+Ikx1pSDTQT/o
2vHNHYLroiHM+zN28aBpih7YsooWjQI=
=4gdL
-----END PGP SIGNATURE-----

--Syeh4y7IR+Jnz+iK--