MIME-Version: 1.0
Message-ID: <trinity-4b8f5f5f-55fe-4c7c-9ba6-d903c722d0d8-1678215174716@3c-app-gmx-bs16>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Daniel Golle <daniel@makrotopia.org>
Cc:     netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Mark Lee <Mark-MC.Lee@mediatek.com>,
        John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Jianhui Zhao <zhaojh329@gmail.com>,
        =?UTF-8?Q?Bj=C3=B8rn_Mork?= <bjorn@mork.no>,
        Alexander Couzens <lynxis@fe80.eu>
Subject: Aw: [PATCH net-next v12 08/18] net: ethernet: mtk_eth_soc: fix
 1000Base-X and 2500Base-X modes
Content-Type: text/plain; charset=UTF-8
Date:   Tue, 7 Mar 2023 19:52:54 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <fd5c7ea79a7f84caac7d0b64b39fe5c4043edfa8.1678201958.git.daniel@makrotopia.org>
References: <cover.1678201958.git.daniel@makrotopia.org>
 <fd5c7ea79a7f84caac7d0b64b39fe5c4043edfa8.1678201958.git.daniel@makrotopia.org>
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:FKFSpgLdtoE=;ggl2He6pfDHWCL4A66ZEN11V2xU
 GjxyNVfMJ/61dmO3ZncoXdVglmIC82xVOp+4YvojI5h3T+PatvIfHWkDQftqu4wNaCe7ASo3U
 y9L8Mhp6FwVrSEDcy75LcTiKxzAD5g/DjOxWylP9eptnnK5SAOgiAJOBEvZhwDWf1SGAMEAj0
 Mrwp4Gdcovx7sBRJmUj/bdfcAbn7Id6GW9bgUTfPzOVuIeWexW2/IInsGl63R7mmXZykSZghP
 SA7YxToaoBy8Lm7H90L2+N8+XPuYyor59xipAJWmndVd4hd7dbxqn3iHpKOkFtfWFHvtxzaBL
 714WMsGX9G7/U6EEaTTT2ngDU0SxLm3cv+x44Bl0XULxoZRYziVFF6d8534IFaqFntZCgfBpg
 iRieo0uX4m84nf5rIxDaa7yBb5pm5Ez140pz4JVRVASlTm/DLem1Ls8Ml1XORAx/eXOgZVyHw
 7vze7jkQRR8Oqx5dMAwPdgABN+mosNIH9kICwTV7MeCFETWnrwQNpT2tlS24lclOWtpKjWXL3
 Q7dqiFe/DVuJFE9i+JzZTThMNpwltcJmbky7s+H3IwyHywUpHcYn1SEJ3VXT4/Jc1OMWZqS7Y
 iEx/xGT2adxKChTNEWWrIxqAYOQDTGGAwMls0rhCbVYBU/0sPp1IpO4XuxEw4YrEicuf1Nf/s
 xqsJiSX2vPixB9d7EhOb0YYlox5uzs/N+VxVgx2aDw0V75jmLQXNoYw/BNA6Z0t+C9tQ2RJ6M
 z/I+0AWwSmC9lx+rIEPMUW0c+Uf8j3X1yvVS4fRUAXtnkQcAg7EV8+mzoTlEuz7zZg2xkNJE4
 9zG7ZVoGjBs4GBKcaYhBgFbQ==
Precedence: bulk

> Gesendet: Dienstag, 07=2E M=C3=A4rz 2023 um 16:53 Uhr
> Von: "Daniel Golle" <daniel@makrotopia=2Eorg>
>
> After conversion to phylink_pcs the 1000Base-X and 2500Base-X modes
> would work only after `ethtool -s eth1 autoneg off`=2E
> As ethtool autoneg and the ETHTOOL_LINK_MODE_Autoneg_BIT is supposed
> to control auto-negotiation on the external interface it doesn't make
> much sense to use it to control on-board SGMII auto-negotiation between
> MAC and PHY=2E
> Set correct values to really only enable SGMII auto-negotiation when
> actually operating in SGMII mode=2E For 1000Base-X and 2500Base-X mode,
> enable remote-fault detection only if in-band-status is enabled=2E
> This fixes using 1000Base-X and 2500Base-X SFPs on the BananaPi R3
> board and also makes it possible to use interface-mode-switching PHYs
> operating in either SGMII mode for 10M/100M/1000M or in 2500Base-X for
> 2500M mode on other boards=2E

Hi,

have tested Parts 1-12 this on bananapi-r3 (mt7986) with 1G Fiber SFP (no =
2g5 available yet) on gmac1 and lan4 (mt7531 p5)

Tested-by: Frank Wunderlich <frank-w@public-files=2Ede>

Thx Daniel for working on SFP support :)

regards Frank