Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752748AbXINHg3 (ORCPT ); Fri, 14 Sep 2007 03:36:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751260AbXINHgU (ORCPT ); Fri, 14 Sep 2007 03:36:20 -0400 Received: from nwd2mail11.analog.com ([137.71.25.57]:16583 "EHLO nwd2mail11.analog.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbXINHgT (ORCPT ); Fri, 14 Sep 2007 03:36:19 -0400 X-IronPort-AV: i="4.20,254,1186372800"; d="scan'208"; a="39601637:sNHT28559419" Subject: Re: [Uclinux-dist-devel] Re: [PATCH] Blackfin arch: add some missing syscall From: Bryan Wu Reply-To: bryan.wu@analog.com To: Mike Frysinger Cc: bryan.wu@analog.com, Bernd Schmidt , bernd.schmidt@analog.com, linux-arch@vger.kernel.org, Matthew Wilcox , Linux Kernel , Paul Mundt , uclinux-dist-devel@blackfin.uclinux.org, Andrew Morton In-Reply-To: <8bd0f97a0709132344w136f2df5ncfe4496c6c895bd8@mail.gmail.com> References: <1189670203.30686.15.camel@roc-desktop> <20070913081852.GC17367@parisc-linux.org> <8bd0f97a0709130137l55977c28w95cf8527ae8b9e24@mail.gmail.com> <1189673849.30686.28.camel@roc-desktop> <46E918FD.3070607@t-online.de> <1189748718.5133.23.camel@roc-desktop> <8bd0f97a0709132344w136f2df5ncfe4496c6c895bd8@mail.gmail.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: Analog Devices, Inc. Date: Fri, 14 Sep 2007 15:32:28 +0800 Message-Id: <1189755148.8165.15.camel@roc-desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 X-OriginalArrivalTime: 14 Sep 2007 07:36:17.0470 (UTC) FILETIME=[EFAE65E0:01C7F6A1] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1847 Lines: 45 On Fri, 2007-09-14 at 02:44 -0400, Mike Frysinger wrote: > On 9/14/07, Bryan Wu wrote: > > On Thu, 2007-09-13 at 13:03 +0200, Bernd Schmidt wrote: > > > Bryan Wu wrote: > > > >>> but mremap doesn't -- there's even an implementation in mm/nommu.c. > > > >>> Could you check the rest of these over to see if they truly don't need > > > >>> to be implemented for no-mmu? > > > >> you're right we want mremap, my fault > > > >> > > > > > > > > Yes, I do think so, both sys_mremap and sys_munmap are implemented in > > > > mm/nommu.c. How do think of this, Bernd? > > > > > > There's a mremap in nommu.c, but it doesn't do a lot that is useful. > > > With some further mm changes in our tree, it's little more than a fancy > > > way of saying munmap, and uClibc does not use it, so there's no > > > compelling need to have it in userspace. > > > > Make sense. So currently Blackfin uClinux use the mremap/munmap in > > uClibc? > > most functions like this dont have any real libc component ... uClibc > will define userspace symbols that merely make a syscall iff the __NR_ > exists in the headers > > if we have __NR_mremap in our unistd.h, we'll automagically get the > mremap() symbol in uClibc which simply passes along the args to the > kernel Yes, I know this. But currently, __NR_mremap does not exit in Blackfin unistd.h: /* 163 __NR_mremap */. So the implementation of this kind syscalls should be in uClibc, right? And Bernd said that the kernel version mremap/munmap is not very useful for Blackfin arch. I think mremap/munmap can be ignored in Blackfin. Thanks -Bryan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/