Message-ID: <50a96bb9-113a-cb06-919c-f544f6b59493@intel.com>
Date:   Tue, 7 Mar 2023 11:28:39 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: selftests: sigaltstack: sas # exit=1 - # Bail out! SP is not on
 sigaltstack - on clang build
Content-Language: en-US
To:     Naresh Kamboju <naresh.kamboju@linaro.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>, <linux-api@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        <lkft-triage@lists.linaro.org>
CC:     Shuah Khan <shuah@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Len Brown" <len.brown@intel.com>, Borislav Petkov <bp@suse.de>,
        Stas Sergeev <stsp@list.ru>, Arnd Bergmann <arnd@arndb.de>,
        Anders Roxell <anders.roxell@linaro.org>
References: <CA+G9fYsi3OOu7yCsMutpzKDnBMAzJBCPimBp86LhGBa0eCnEpA@mail.gmail.com>
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <CA+G9fYsi3OOu7yCsMutpzKDnBMAzJBCPimBp86LhGBa0eCnEpA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1dwL1dnVDV3MmZNQXM1ZFVEK2s1RmxXQW55dnZzR3dwZjh3T1hraHJNRXdN?=
 =?utf-8?B?UkpqTE5ibjkreUdldktZRDk1ejkyOVVrU1B0ZVZNd3k4U20zNEdKTUJaRUo2?=
 =?utf-8?B?ZHhlY2g5WkQweWxLclFjSjI2SXRDSCt4N0dvTVVJL0xtY2Iwa29lVGkvQ2I0?=
 =?utf-8?B?RndLN2NxV2t1Sko4cXczNWZIQzVpbDZYOTJzNEVaUWNhb0dMOG1KL21NMEN4?=
 =?utf-8?B?MmI2UENIdHl5WFRXZFJPeWtHTUJQSWhJSEVwc0s2dWg4ZG9oL3ZiaUZ2WW50?=
 =?utf-8?B?UllleXVGTXNKZ3JRNEE5MklXQjdpc3dHczE4TnZyYVZQNGpMUFV0OHI1eVdI?=
 =?utf-8?B?M3ZYdGV2WHlMRWpLd2hnaG85OTR1V0FUazh0RGlKNHh3c1hQYVM1M1FwaEFv?=
 =?utf-8?B?Wm5lNGZadUJaQUhMczlYK2FPREFNWUZxRTIrekE3czFJYzNqMFNsazEyQm03?=
 =?utf-8?B?elp4UnQ2bm5pMnBpdmxrcytlbVZyUkc5WTZFNTh6TXRUR2VoV0k3ejFrbzd5?=
 =?utf-8?B?U2UrckJPNkp6aWhvNW82cEN2L0l5U3QwT2ZGTWszQXhkbzdqVnJteWU5UVI0?=
 =?utf-8?B?by9aVlNYeFk0cm0yTnQwZTZOYURIVzc1bTV1MEF4N0hzMWlldXZkd3IzVUd5?=
 =?utf-8?B?NC9NS0VYNFJFNVF1ckVESHJyaG41T2UzNTRObzB3N2JCakJQOGcvLzV4TW1l?=
 =?utf-8?B?VUtBMWFNbnZrNkQ1d0x5RnRxdE1QdytoRzlhS3pSVUFMTlV3VGZQYmJoNGVV?=
 =?utf-8?B?SUo5ZEFZZ09ZOXJwWmM5dUJBQ0o5ZnVmcm1UajF0b1Q3c3JZdWVaN3dKRmNj?=
 =?utf-8?B?NTB3Rzc0Qkh3cjExaE52QSt1eG9xWVF6L2VEaUhHQjBkMVNmNWgvN24xTTR2?=
 =?utf-8?B?WmpPSnQvUEdNWGlGQ3FzV2gyakJZM04zL0NKa3JLMDBxZzNCcUo1V2s5VDBw?=
 =?utf-8?B?elFpZTcrbFdGcUJ4OTZMY21IeStNbjJvQVlOcGF2QTdueld5bEJ5d1QvOWw0?=
 =?utf-8?B?UjhRNnZ5eXBkSGFZMFkwQXZuQnVlSzJQUG03ZG5HS2xRZmFjOG5VVU9HRk53?=
 =?utf-8?B?NTZwUmtBRFlROFJGRHV4NWZWazZuaURqYlBuM2tkWHlFU0ZZdmFwZTg3N2tj?=
 =?utf-8?B?TG9ab1BGcjRhVkIxZlBCVE5JbmJoamdGMEJ4aGxCL25Sd1cxaTc3MkVJY201?=
 =?utf-8?B?dlRhck83emVDeXJDREszQS9FblU3TlJBSnYrSk5tY1JYZVNjcFdPOGhvUUlI?=
 =?utf-8?B?Z0RsaWx4b3QrS0N5Tk0vUkRPQW5aZFFuUWpHQm9DcFdHYjJZOXBIZUN3SExo?=
 =?utf-8?B?S1NONjRQLzg0emV2REV0Y0ZrY2pERXpRZ0ZEajVtM1p6bnVXSjB1WWlZc3JD?=
 =?utf-8?B?Z0xBbGFKeHpGUnRSWTlZL1owcWFrZ3NlNUtHcWpHSHV5aUhUZEpIYzFabXlq?=
 =?utf-8?B?cXU0d3NsODRHYzAvU3hDSUtaWlYvcGpzMkpYdEVLNC9zZG9QN2oxNmIwOE9Y?=
 =?utf-8?B?OHNwVnZlclYxVXpaZ2JDQUJwL09wTkR1NjVwdzhNLzAxYkR2aG1wYW84N3Vv?=
 =?utf-8?B?eU5Ed2pKeW5IWm1vZjhLRCtZV0FqUVpiS1N6a2xBZXk3RnRTeitoZ1pIWDFR?=
 =?utf-8?B?T1pZUGJHb29xRTlrWjJ0ODh6YXVIWjBTM3RCbkRFUCtmb21lS0JFeFBxZjMz?=
 =?utf-8?B?a2x1QmpldUZ2U1R2ajF3RGYxUGVGNTdFUi9VMDFCWWhUVHB0dURKUm9HTXZS?=
 =?utf-8?B?RVJPeWpXSVZLQ2p0dEVrUGNpSHhOdlBXRysrSWtIeFBQMlg1R25CLzZYdHhQ?=
 =?utf-8?B?ejJMWHh3OXNYdmlBT2RqcS9FVVlBMEhoWm5DbndDcnVsaEZSdWYrUmkrME1y?=
 =?utf-8?B?QmRUenYwTFFCVWsrcitPdTZMeDQ4b2J0eDVOeTFHMGJWODZRVFpXSCtuYUxa?=
 =?utf-8?B?WXd0VFdyVjVpeFY5cVhVcHhjVDlBS2k4azUya2k2WTQycHBmclNqY0NJWlNW?=
 =?utf-8?B?MnIzSHNsTVRKWjc5TUx6Wkp5cGtDaUZaVllmMFFRUmhmbklCTXZ2RUlDeHht?=
 =?utf-8?B?YkVscWJUdDBnRnBISnpkQWVTY3lISGZoYlVYM1ZZV2Z4M3M4ZEdlZzkxWU9v?=
 =?utf-8?B?eTVRNDBhZ0tZaUJib3BiREdaQmhXOU1xa3pXRDk1cWMxS3RSb0tPU3o4Mzlh?=
 =?utf-8?B?NkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd43c213-df25-4fe9-0440-08db1f422944
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 19:28:42.6026
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 20LyCwNNnXo0lkyQJ0JR58p4lOUgQ4jwu7iETayLF2lUBva5F9KnPnTuNEu+0vWG/OTxKyb/25r+8FUJit6ABya2Pjjo0Bm/YReG5vy/TEc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6171
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/6/2023 10:57 PM, Naresh Kamboju wrote:
> kselftest: sigaltstack built with clang-16 getting failed but passed with
> gcc-12 build. Please find more details about test logs on clang-16 and
> gcc-12 and steps to reproduce locally on your machine by using tuxrun.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> Test log:
> ----------
> 
> Linux version 6.3.0-rc1-next-20230307 (tuxmake@tuxmake) (Debian clang
> version 16.0.0 (++20230228093516+60692a66ced6-1~exp1~20230228093525.41),
> Debian LLD 16.0.0) #1 SMP PREEMPT @1678159722
> ...
> kselftest: Running tests in sigaltstack
> TAP version 13
> 1..1
> # selftests: sigaltstack: sas
> # # [NOTE] the stack size is 21104
> # TAP version 13
> # 1..3
> # ok 1 Initial sigaltstack state was SS_DISABLE
> # Bail out! SP is not on sigaltstack
> # # Planned tests != run tests (3 != 1)
> # # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0
> not ok 1 selftests: sigaltstack: sas # exit=1
<snip>

> Linux version 6.3.0-rc1-next-20230307 (tuxmake@tuxmake)
> (aarch64-linux-gnu-gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils
> for Debian) 2.40) #1 SMP PREEMPT @1678159736
> ...
> kselftest: Running tests in sigaltstack
> TAP version 13
> 1..1
> # selftests: sigaltstack: sas
> # # [NOTE] the stack size is 50080
> # TAP version 13
> # 1..3
> # ok 1 Initial sigaltstack state was SS_DISABLE
> # # [RUN] signal USR1
> # ok 2 sigaltstack is disabled in sighandler
> # # [RUN] switched to user ctx
> # # [RUN] signal USR2
> # # [OK] Stack preserved
> # ok 3 sigaltstack is still SS_AUTODISARM after signal
> # # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0
> ok 1 selftests: sigaltstack: sas

At glance, the log shows the altstack size difference between LLVM and GCC.

But, when I tried with the LLVM that I have,

     $ clang --version
     clang version 13.0.0 ...

it failed only with this compiler:

     $ rm sas;clang -o sas sas.c;./sas
     # [NOTE]        the stack size is 8192
     TAP version 13
     1..3
     ok 1 Initial sigaltstack state was SS_DISABLE
     Bail out! SP is not on sigaltstack
     # Planned tests != run tests (3 != 1)
     # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0

     $ rm sas;gcc -o sas sas.c;./sas
     # [NOTE]        the stack size is 8192
     TAP version 13
     1..3
     ok 1 Initial sigaltstack state was SS_DISABLE
     # [RUN] signal USR1
     ok 2 sigaltstack is disabled in sighandler
     # [RUN] switched to user ctx
     # [RUN] signal USR2
     # [OK]  Stack preserved
     ok 3 sigaltstack is still SS_AUTODISARM after signal
     # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0

The same is true with some old versions -- e.g. the one that came with 
commit 0c49ad415512 ("tools/testing/selftests/sigaltstack/sas.c: improve 
output of sigaltstack testcase"):

     $ rm sas;clang -o sas sas.c;./sas
     [OK]    Initial sigaltstack state was SS_DISABLE
     [FAIL]  SP is not on sigaltstack

     $ rm sas;gcc -o sas sas.c;./sas
     [OK]    Initial sigaltstack state was SS_DISABLE
     [RUN]   signal USR1
     [OK]    sigaltstack is disabled in sighandler
     [RUN]   switched to user ctx
     [RUN]   signal USR2
     [OK]    Stack preserved
     [OK]    sigaltstack is still SS_AUTODISARM after signal
     [OK]    Test passed

So, this test failure appears to have been there for a while. I think 
the LLVM folks need to take a look at it.

Thanks,
Chang