Message-ID: <d5a75826-d762-27fc-5820-6826debdecd9@amd.com>
Date:   Wed, 8 Mar 2023 01:55:39 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH V6 8/8] soundwire: amd: add pm_prepare callback and pm ops
 support
Content-Language: en-US
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        vkoul@kernel.org
Cc:     alsa-devel@alsa-project.org, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, Mario.Limonciello@amd.com,
        amadeuszx.slawinski@linux.intel.com, Mastan.Katragadda@amd.com,
        Arungopal.kondaveeti@amd.com, claudiu.beznea@microchip.com,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Sanyog Kale <sanyog.r.kale@intel.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20230307133135.545952-1-Vijendar.Mukunda@amd.com>
 <20230307133135.545952-9-Vijendar.Mukunda@amd.com>
 <4330af6a-ce97-53ed-f675-6d3d0ac8f32f@linux.intel.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <4330af6a-ce97-53ed-f675-6d3d0ac8f32f@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHY2cHRUYnlwbGZ0aEZRL1JGQjBYMWQ0TmF1LzNCQ01BY2V6b0ZPT0s1SEkx?=
 =?utf-8?B?SE1lR3g4eGRRTzI1K2w4ME56RGlXRWw5bjRuUmh4N29DOTkzWDJITDNQYnUv?=
 =?utf-8?B?cERDRjEvSnlRM1dHQUlPMzhkZnpQQlpJUDlnZGNIWjM3U1drRXJlc1VmSzR3?=
 =?utf-8?B?emlmTEE3UGIrVTlYRTRHTXRsd25CSXdzdk1vM2JHUkUvdHNUcnVCSURqejJS?=
 =?utf-8?B?MVZyQ2JvRW9MUjluWDY1elcyQ1l6M3ltWTY2M21HbEpTN0hRZzc4OXN5YU9l?=
 =?utf-8?B?b3BnSFhXQmJPV3ZBQTZSSExaclRVNGk0Rm14Y3hIUWhpYU85Mm5ISGJBVXdj?=
 =?utf-8?B?ejVGNytXTHpkbW5ORDJTUXo4a0xvVHB4a1BJREhSUU5TUldpQ21WSVhhR0JO?=
 =?utf-8?B?R1RqR2pYRnZZR2pEbTFNZktDTGFHb2FqNmdSOVJGc0s1Ny9QNHlrWHFNQW0z?=
 =?utf-8?B?eGRnZUtObWZ5M3ZZMFlkdjFsSjhwYklkdEtJVkJzMTlSNUQ5T1NTUFc3Y3JR?=
 =?utf-8?B?SldNNVJpSU5ZbU1sRVlCS0twV2w2ZHMvWEFZOHo1ZEIrbW9sQTRUTS9ubGdz?=
 =?utf-8?B?dG9xeDViN3JpMC9ZUnRvUVlBak90OUxCRGwya3dJTllUZG9SN1NTQ2xvRCtu?=
 =?utf-8?B?MWdSNVNDUUhUZU5pQlA5Y2JMRlgwYlpFd2VDNW44cHlrck5GZktjdW81Z3lj?=
 =?utf-8?B?eGlmOGt6ZDlkVjVOQm9nbkNyTWVBNHFwMWEvWVBIejhQMm5Rb0NIRUVpekpw?=
 =?utf-8?B?eUVkUTYzd3hZa1QzL3ZScjhvN3FrWW5XY3djR25vOSszZldmNjhiRVJWQmVx?=
 =?utf-8?B?T3RzV2s5UzBaY1VpSHkySXJjQUlMOGZETkY0NkNsM0RiOXpNS3VnYS93UlFS?=
 =?utf-8?B?cVAvZDliYWZwVWVEK3N0K0RxMDVtRmw4eUlXdis1WWNpazNuWU9kRjNPNWdT?=
 =?utf-8?B?MW9aZ0ZGZ1JFbmJIS3BacHpwMyt6QXU0M0ZMOVRPTVNtaERqNlgzZ2ZvQXFE?=
 =?utf-8?B?cTRjMWRTVkU0R0FxbmI2aGpCWHVXTVc0enlucUx3MkR2aVJsRnJoZ0ppQnF6?=
 =?utf-8?B?OUUremk3VmNKejVNZUk4eTBSanJqck5hdlZKYXZ2aUtudWJoOVNXZ1FCUzRn?=
 =?utf-8?B?ekcwZCszRXEwN2lNUjNnRXBWU1dVZlVOaGpIMFlvS1ZwNWxlalhNZzVIeGtB?=
 =?utf-8?B?Q2wvWm5kZkNSNDhuRlJkT0U5Z1Z4MEFDLzk4VkZhUUVZMGROc0QvV3A3K2dY?=
 =?utf-8?B?ZnVUbEtDR0pxYjJsMDlUYzI0eThyRDVkeTEwVDduQi9QVG1DMlpOY3J0SHFQ?=
 =?utf-8?B?MTZZLy9jMTdTcHF5S0pSa2N0MWVxWjk1Um54Sm85OFdBVnA4UlA0aWVpaUoy?=
 =?utf-8?B?SzhCT2RjU29raE00d2FBbTJDRXRTMUdleGFCQmhVa1ZzcWoxTVp4RTFiMjlW?=
 =?utf-8?B?RXVaRWhKNHkzZy9YZVpNc21RK2Z0M0psYVppSFFrZ0pWcFJ3K3dSMVZxc0lo?=
 =?utf-8?B?SS9vM0NlTjFNSzFXWnlndWhzdktGd1d5d3VnRnlIZENVcFRRRU5heDVqdmJq?=
 =?utf-8?B?RFJxTWY3TTJzVGgzQ0t0ZXY2OFR4eWhHWXo3RER3d0F5aXlmNXBjY3lmMW5k?=
 =?utf-8?B?Yy9HRUpPVVRQamFpQkpKUFdTK1FVdUFnYTlHbmgvclQ1OURnQ1VBYXgyeFZZ?=
 =?utf-8?B?Zld1bU9ZRzJXMGw2emhlS2pyWUdBdmxGaDM1VjZtWGZ3WGNXaWgwa2ZSTS9y?=
 =?utf-8?B?VUNJTWZ0U21NUVIxUGJMeXNrUUFISWJkV0loZWhDd043NW90bTFpeGxJVy9l?=
 =?utf-8?B?cUJTNnRBYXp3OEpBM2tSdC9PUjdDdTM3SVlBWjA0d05hV09XRHZ6NnFxSjlC?=
 =?utf-8?B?bm91Q1lFWENWeHJzckNSUXBSU1pGSnhUSzZOYzdDeFM4UVdWMFkxTTNra0tW?=
 =?utf-8?B?YUVmNnJUODM0L243ZUc0K1phUmVKWGVONUx6d1dCbG9hUlZXWE1VU0h5dktZ?=
 =?utf-8?B?ajBZaHM4RWozRmJUbWR3cDZ1bjFZS1I5OEUyMU0yeVJTOUlBRWt5c3hKcWdM?=
 =?utf-8?B?WWpoSEhQRkZJU1JxVEs3VFBBY2VReVZvWHdmNG9IV3hjMlZRWTJUZ2lhSFRm?=
 =?utf-8?Q?rzFObkxAdyyGf4miSELPh6TXJ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9693429b-2206-41fa-a0de-08db1f49931b
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 20:21:46.8097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gybYq36Pdmmb5uGNtcoM0BNqRTLjcyuM7rC8Kz+rrS06pKM9yhdOCWEpZS6y7PPoc8AeG0VleqxRSvxq4ryGdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6418
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/03/23 20:58, Pierre-Louis Bossart wrote:
>> +static int amd_resume_child_device(struct device *dev, void *data)
>> +{
>> +	struct sdw_slave *slave = dev_to_sdw_dev(dev);
>> +	int ret;
>> +
>> +	if (!slave->probed) {
>> +		dev_dbg(dev, "skipping device, no probed driver\n");
>> +		return 0;
>> +	}
>> +	if (!slave->dev_num_sticky) {
>> +		dev_dbg(dev, "skipping device, never detected on bus\n");
>> +		return 0;
>> +	}
>> +	if (!pm_runtime_suspended(dev))
>> +		return 0;
>> +	ret = pm_request_resume(dev);
> I still don't get why the test above was needed. It's racy and brings
> limited benefits.
As explained below thread,

https://lore.kernel.org/lkml/acd3a560-1218-9f1d-06ec-19e4d3d4e2c9@amd.com

Our scenario is multiple peripheral devices are connected
over the same link.

In our implementation, device_for_each_child() function invokes
amd_resume_child_device callback for each child.
When any one of the child device is active, It will break the
iteration, which results in failure resuming all child devices.

If we skip , pm_suspended check , it will not resume all
peripheral devices when any one of the peripheral device is active.
>
>> +	if (ret < 0)
>> +		dev_err(dev, "pm_request_resume failed: %d\n", ret);
>> +
>> +	return ret;
>> +}