MIME-Version: 1.0
References: <20230307192449.24732-1-bp@alien8.de> <20230307192449.24732-10-bp@alien8.de>
In-Reply-To: <20230307192449.24732-10-bp@alien8.de>
From:   Dionna Amalie Glaze <dionnaglaze@google.com>
Date:   Tue, 7 Mar 2023 12:27:42 -0800
Message-ID: <CAAH4kHbaiBOxJZbZv+fvnstGknugjvhR5uWKK8aBXM2rDBGdRQ@mail.gmail.com>
Subject: Re: [PATCH -v3 09/11] virt/coco/sev-guest: Add throttling awareness
To:     Borislav Petkov <bp@alien8.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Joerg Roedel <jroedel@suse.de>,
        Michael Roth <michael.roth@amd.com>,
        Nikunj A Dadhania <nikunj@amd.com>,
        Peter Gonda <pgonda@google.com>,
        Tom Lendacky <Thomas.Lendacky@amd.com>,
        linux-coco@lists.linux.dev, x86@kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> @@ -320,7 +323,8 @@ static int enc_payload(struct snp_guest_dev *snp_dev, u64 seqno, int version, u8
>
>  static int __handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, __u64 *fw_err)
>  {
> -       unsigned long err, override_err = 0;
> +       unsigned long err = 0xff, override_err = 0;
> +       unsigned long req_start = jiffies;
>         unsigned int override_npages = 0;
>         int rc;
>

Not blocking, but I do think in the previous version we discussed
changing this to the SEV_RET_NO_FW_CALL value instead of 0xff. I agree
that should be a later cleanup.

--
-Dionna Glaze, PhD (she/her)