From:   "Li, Xin3" <xin3.li@intel.com>
To:     "Li, Xin3" <xin3.li@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>
Subject: RE: [PATCH v5 34/34] KVM: x86/vmx: execute "int $2" to handle NMI in
 NMI caused VM exits when FRED is enabled
Thread-Topic: [PATCH v5 34/34] KVM: x86/vmx: execute "int $2" to handle NMI in
 NMI caused VM exits when FRED is enabled
Thread-Index: AQHZUKI3WfAyEb/jCU66DZKXu8CGnq7v3nLw
Date:   Tue, 7 Mar 2023 22:00:40 +0000
Message-ID: <SA1PR11MB6734409CB3CA1521323A1C7FA8B79@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <20230307023946.14516-1-xin3.li@intel.com>
 <20230307023946.14516-35-xin3.li@intel.com>
In-Reply-To: <20230307023946.14516-35-xin3.li@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VoFzQQFIw+k4NJKHj8pWwoeDvhH6VlNRoOBNRLdlelMDPh82a0CUJZznEO3n?=
 =?us-ascii?Q?G+7n3w5uhSU7JW7ZF6ISWKBRQQeNa6rcfDYVXkYXdn4C33t1RoxuiYFcD2yq?=
 =?us-ascii?Q?7xECCtGHuIw3n0CFYTF1FwoKzsvIdoVZmk0yKm2U3nrhEF9HVg1X+ydA9v1o?=
 =?us-ascii?Q?ln/lyK3JDII91Xr5jvcP5P5qDYHZQN/KRIClCpyEuVgo1t989uoE2UNQVfqI?=
 =?us-ascii?Q?0KKa5P2hTAqcaToLYINCBPYDEF2mZDvKSA0HG4sDakPHbXXrFnHp8if/XbE6?=
 =?us-ascii?Q?tdX4SQ28emB4ayRuqLs3MraQwMf1xE+Td/R583myO++BGAyquP+xMYywD/ye?=
 =?us-ascii?Q?OcOvNd6x8vYSvq0Xy6AOcICsN9JM+R4VqsAMBO0ovg+GDmUenEXUT04x0irr?=
 =?us-ascii?Q?Pe6YFJHq0AHltwpYXSjfNF4BMn3fxb6YECTuz0HTrgKfhe/p6so1pRondbNm?=
 =?us-ascii?Q?oitmZBa0OJf9H0yZu1uuGgKh6F5Umbr9v3IjHm7QtkAerNaQvlQgYojll14P?=
 =?us-ascii?Q?phWfBug1YRjPlQ/4NA9YDWgLHq2cMaVahOyi7i8wveC/8SMcOfA4M6K7q0H7?=
 =?us-ascii?Q?8buaost1YUnMlWB8phxPB4QoSFAtJu7C+XEVYsGFWZpUSVMW0bFePqu8UVhO?=
 =?us-ascii?Q?QVi11g1aSPuYoChNdE1DyVqLeXAbTiQm1hNiBSTxzzNfqztq2qbAs0jfFQzD?=
 =?us-ascii?Q?KVGfA18hpLY12Cu3KiikOjLrVPbVT+XPC3blqDcM5pvAqPDWPopp5HOBiHqF?=
 =?us-ascii?Q?oPLX2dPD+GCAR+3tC6WdxPU2V62kMzrWYMjo6V8U6Gwdge+aSOItHTiySRce?=
 =?us-ascii?Q?zOEofDV/XY3A51SLN7RzRY45n7lh76kfy5cO5pudrnqeCSerwdlBmNd3Rp6D?=
 =?us-ascii?Q?2ALO/Uu0+8M0ecKyNtzHVnNEMVQOmG+eFyYtvOtlA82hVOsx6Ys1LLWw4c7z?=
 =?us-ascii?Q?wrYKcjeJu3JoLupB8zz506bJMAp5vCaH2r62aRR58UMvhWJVOblpq3ICSGDk?=
 =?us-ascii?Q?FW0gA8PSimJ07v+j0fQUaIBd7KJ9UAA6fS061CEA6wQNz5+2VQyEAQfacBac?=
 =?us-ascii?Q?nrKpSFB2ZL1Y9kdorKg6wmpvrepCVig8af9HhnXDnfrq4Q+Ur9hpFm3lxWJT?=
 =?us-ascii?Q?A8aH/TNJOTb3sRmt6PfVpZLEHHoKvX/SOSOQCAplIhTSS0k73Kvc+HE8AGYh?=
 =?us-ascii?Q?7RUwxl1/+tT1aNksxw/HnVFPg7fjeOHaAdkZCHV+boDdkrK/NO1lo06c2YZL?=
 =?us-ascii?Q?aGyadclGkli5x7LyjHyd56YOKNYt0Ul85xoxEi8mV6IDqBVkaEkud5q8aPPJ?=
 =?us-ascii?Q?TaVzz/lTtqw9J/Ucy7Xcj4M0DRDmj5A7SVvep/9PoirfQTQ7MsBF/ColNXAc?=
 =?us-ascii?Q?FbdFdYVWB41EhZ0DNz6Vk74YofFrYbELrcM5k50R1l1PgDc9uCwKcCajij/j?=
 =?us-ascii?Q?WkbD9BlwSVQIXhqn3mHQKcLGc63931b/DgFmOtPL5XRKsb2lObr0yvougeiE?=
 =?us-ascii?Q?X0iSZmpikUzHY8BWh8pbf+n9AwjibVASOMju9ili6PUo+Dz4AOgaRnFngWid?=
 =?us-ascii?Q?KC12GEg2pj/sgbifDZI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7eee1ce0-5b5e-41e4-4eff-08db1f576422
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2023 22:00:40.5486
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w3FZuqnjhOuTLLmCRVJzkoj4bu2PyLwKmGtF7VHZeFqTD3psQkW611yKWsX8sIBz1DxGmD1DEoNz/rkas0Z5RQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7385
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Execute "int $2" to handle NMI in NMI caused VM exits when FRED is enable=
d.
>=20
> Like IRET for IDT, ERETS/ERETU are required to end the NMI handler for FR=
ED
> to unblock NMI ASAP (w/ bit 28 of CS set). And there are 2 approaches to
> invoke the FRED NMI handler:
> 1) execute "int $2", let the h/w do the job.
> 2) create a FRED NMI stack frame on the current kernel stack with ASM,
>    and then jump to fred_entrypoint_kernel in arch/x86/entry/entry_64_fre=
d.S.
>=20
> 1) is preferred as we want less ASM.
>=20
> Tested-by: Shan Kang <shan.kang@intel.com>
> Signed-off-by: Xin Li <xin3.li@intel.com>
> ---
>=20
> Changes since v4:
> *) Do NOT use the term "injection", which in the KVM context means to
>    reinject an event into the guest (Sean Christopherson).
> *) Add the explanation of why to execute "int $2" to invoke the NMI handl=
er
>    in NMI caused VM exits (Sean Christopherson).

Sean,

Do you have any further issue with the last 2 VMX patches?

If not, would you ack them?

Thanks!
  Xin


> ---
>  arch/x86/kvm/vmx/vmx.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>=20
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 3ebeaab34b2e..4f12ead2266b 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7229,7 +7229,16 @@ static noinstr void vmx_vcpu_enter_exit(struct
> kvm_vcpu *vcpu,
>  	if ((u16)vmx->exit_reason.basic =3D=3D EXIT_REASON_EXCEPTION_NMI &&
>  	    is_nmi(vmx_get_intr_info(vcpu))) {
>  		kvm_before_interrupt(vcpu, KVM_HANDLING_NMI);
> -		vmx_do_nmi_irqoff();
> +		/*
> +		 * Like IRET for IDT, ERETS/ERETU are required to end the NMI
> +		 * handler for FRED to unblock NMI ASAP (w/ bit 28 of CS set).
> +		 *
> +		 * Invoke the FRED NMI handler through executing "int $2".
> +		 */
> +		if (cpu_feature_enabled(X86_FEATURE_FRED))
> +			asm volatile("int $2");
> +		else
> +			vmx_do_nmi_irqoff();
>  		kvm_after_interrupt(vcpu);
>  	}
>=20
> --
> 2.34.1