Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Mariusz Tkaczyk" <mariusz.tkaczyk@linux.intel.com>
Cc:     "Song Liu" <song@kernel.org>,
        "Linux regressions mailing list" <regressions@lists.linux.dev>,
        Jes.Sorensen@gmail.com, "linux-raid" <linux-raid@vger.kernel.org>,
        "LKML" <linux-kernel@vger.kernel.org>,
        "Nikolay Kichukov" <hijacker@oldum.net>
Subject: Re: [regression] Bug 217074 - upgrading to kernel 6.1.12 from 5.15.x
 can no longer assemble software raid0
In-reply-to: <20230307095258.00001cb3@linux.intel.com>
References: <a13cd3b5-cc41-bf2f-c8ac-e031ad0d5dd7@leemhuis.info>,
 <CAPhsuW7ZWthh0PZt71hQh1_51C0yMSpOqWYJKc_+VzzTmW_r5A@mail.gmail.com>,
 <167805126796.8008.3635368722810568057@noble.neil.brown.name>,
 <20230307095258.00001cb3@linux.intel.com>
Date:   Wed, 08 Mar 2023 09:33:52 +1100
Message-id: <167822843274.8008.1142380266687607670@noble.neil.brown.name>
Precedence: bulk

On Tue, 07 Mar 2023, Mariusz Tkaczyk wrote:
> On Mon, 06 Mar 2023 08:21:07 +1100
> "NeilBrown" <neilb@suse.de> wrote:
>=20
> > On Sat, 04 Mar 2023, Song Liu wrote:
> > > + Jes.
> > >=20
> > > It appeared to me that we can assemble the array if we have any of the
> > > following:
> > > 1. Enable CONFIG_BLOCK_LEGACY_AUTOLOAD;
> > > 2. Have a valid /etc/mdadm.conf;
> > > 3. Update mdadm to handle this case. (I tried some ugly hacks, which wo=
rked
> > > but weren't clean).
> > >=20
> > > Since we eventually would like to get rid of CONFIG_BLOCK_LEGACY_AUTOLO=
AD, I
> > > think we need mdadm to handle this properly. But the logistics might
> > > be complicated, as
> > > mdadm are shipped separately.
> > >=20
> > > Jes, what do you think about this? AFAICT, we need to update the logic =
in
> > > mdopen.c:create_mddev(). =20
> >=20
> > mdadm already handles this, but only if=20
> >    CREATE names=3Dyes
> > is present in /etc/mdadm.conf
>=20
> Hi,
>=20
> "CREATE names=3Dyes" enforces creation of /dev/md_name arrays instead of
> /dev/mdXXX. It is a large change for users, too aggressive IMO. It will des=
troy
> many setups.
>=20
> To resolve it, we need is to use create_named_array() but respect old naming
> convention. We already have find_free_devnm(), and we are able to keep
> consistency because we can create 'mdXXX':
>=20
> /sys/module/md_mod/parameters # echo md125 > new_array
>=20
> /sys/module/md_mod/parameters # ll /sys/block/md125
> lrwxrwxrwx 1 root root 0 Mar  7 10:54 /sys/block/md125 ->
> ../devices/virtual/block/md125
>=20
> That will require adjustments in mdadm, but I think that we can keep
> names the same way. I created the test for verification of base creation fl=
ows,
> we can use it to avoid regression:
> https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/tree/tests/00createnam=
es
>=20
> Thoughts?

Yes, that is probably sensible.

It would be nice to have a way to expose the "names=3Dyes" functionality
more obviously.  I think people would generally prefer it (/proc/mdstat
becomes more meaningful) but I agree that forcing it on people is the
the best approach.

Maybe a super-block flag that enables it for that array, and we start
setting that flag when creating new arrays?

NeilBrown


>=20
> BTW. I wanted to get rid of this legacy "create_on_open" from mdadm anyway =
but
> never had time to. If you agree, I can proceed with fixing it.
>=20
> Thanks,
> Mariusz
>=20