Message-ID: <d119fcba-a323-d0cd-0d36-759ad2fb8252@acm.org>
Date:   Tue, 7 Mar 2023 14:35:09 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH-next v2 Resend] scsi: fix use-after-free problem in
 scsi_remove_target
Content-Language: en-US
To:     Zhong Jinghua <zhongjinghua@huaweicloud.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhongjinghua@huaweicloude.com, yi.zhang@huawei.com,
        yukuai3@huawei.com
References: <20230306121636.3183761-1-zhongjinghua@huaweicloud.com>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20230306121636.3183761-1-zhongjinghua@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/6/23 04:16, Zhong Jinghua wrote:
> +			/*
> +			 * If the reference count is already zero, skip this
> +			 * target is safe  because scsi_target_destroy()
> +			 * will wait until the host lock has been released
> +			 * before freeing starget.
> +			 */

The above comment has grammatical issues and is confusing. I think the 
comment that I suggested was much better than the above.

Bart.