Date:   Tue, 7 Mar 2023 18:25:15 -0600
From:   Rob Herring <robh@kernel.org>
To:     Miquel Raynal <miquel.raynal@bootlin.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Walle <michael@walle.cc>,
        =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Robert Marko <robert.marko@sartura.hr>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v2 05/21] of: Move the request module helper logic to
 module.c
Message-ID: <20230308002515.GC513330-robh@kernel.org>
References: <20230307165359.225361-1-miquel.raynal@bootlin.com>
 <20230307165359.225361-6-miquel.raynal@bootlin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230307165359.225361-6-miquel.raynal@bootlin.com>
Precedence: bulk

On Tue, Mar 07, 2023 at 05:53:43PM +0100, Miquel Raynal wrote:
> Depending on device.c for pure OF handling is considered
> backwards. Let's extract the content of of_device_request_module() to
> have the real logic under module.c.
> 
> The next step will be to convert users of of_device_request_module() to
> use the new helper.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  drivers/of/device.c | 25 ++-----------------------
>  drivers/of/module.c | 30 ++++++++++++++++++++++++++++++
>  include/linux/of.h  |  6 ++++++
>  3 files changed, 38 insertions(+), 23 deletions(-)

Other than the licensing inherited,

Reviewed-by: Rob Herring <robh@kernel.org>