Date:   Wed, 8 Mar 2023 00:33:59 +0000
Message-ID: <01010186bea3a046-f1f68507-2d3c-41c3-9066-44199e2ce071-000000@us-west-2.amazonses.com>
To:     bjorn3_gh@protonmail.com
Cc:     daniel.almeida@collabora.com, wedsonaf@gmail.com, ojeda@kernel.org,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, kernel@collabora.com
Subject: Re: [PATCH] rust: virtio: add virtio support
From:   FUJITA Tomonori <tomo@exabit.dev>
In-Reply-To: <OBVROfBri9SuVdfyos-71URYovcNLhbDb_50cECWMwhycY2sHH90w28f0qlJ_q_dMuCnOD_4nQCVUnwOkgyCEH1298nsVLW0YFuuiIlLPow=@protonmail.com>
References: <20230307130332.53029-1-daniel.almeida@collabora.com>
        <OBVROfBri9SuVdfyos-71URYovcNLhbDb_50cECWMwhycY2sHH90w28f0qlJ_q_dMuCnOD_4nQCVUnwOkgyCEH1298nsVLW0YFuuiIlLPow=@protonmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Feedback-ID: 1.us-west-2.j0GTvY5MHQQ5Spu+i4ZGzzYI1gDE7m7iuMEacWMZbe8=:AmazonSES
Precedence: bulk

On Tue, 07 Mar 2023 17:09:27 +0000
Bj=F6rn Roy Baron <bjorn3_gh@protonmail.com> wrote:

> On Tuesday, March 7th, 2023 at 14:03, Daniel Almeida <daniel.almeida@=
collabora.com> wrote:
> =

>> This patch adds virtIO support to the rust crate. This includes the
>> capability to create a virtIO driver (through the module_virtio_driv=
er
>> macro and the respective Driver trait) as well as initial virtqueue
>> support.
>> =

>> A sample virtIO module is included for conveninence.
>> =

>> Signed-off-by: Daniel Almeida daniel.almeida@collabora.com
>> =

>> ---
>> =

>> Ok so this is my first Rust contribution here. It's part of a virtIO=

>> driver I was originally writing. Both the probing and the virtqueue
>> support in here were confirmed as working in said prototype driver, =
and
>> the pieces were picked separately into this patch.
>> =

>> Feel free to point me to the best practices around Rust patch
>> submission, as the C stuff like checkpatch etc probably does not app=
ly
>> yet. I did take care to run clippy though.
>> =

> =

> Great to see Rust support for the driver side of VirtIO! I've got a c=
ouple of review comments, but I don't see any big issues. Maybe you cou=
ld write an actual driver which uses add_sgs though? It doesn't have to=
 be complicated, but just something to show how it will work. That may =
help with checking if the api is usable. You might try something like v=
irtio-console or virtio-entropy I think.

There was an attempt to implement virtio-net, which might be useful:

https://github.com/Rust-for-Linux/linux/pull/886

C versions of virtio-console, virtio-rng, and virtio-net exists. Both
C and Rust versions in mainline?

Are there guidelines on pushing a Rust driver in mainline?