Message-ID: <a35b728d-90c8-60dc-04d1-d1762f26b8a2@huaweicloud.com>
Date:   Wed, 8 Mar 2023 09:15:40 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH-next v2 Resend] scsi: fix use-after-free problem in
 scsi_remove_target
To:     Bart Van Assche <bvanassche@acm.org>, jejb@linux.ibm.com,
        martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhongjinghua@huaweicloude.com, yi.zhang@huawei.com,
        yukuai3@huawei.com
References: <20230306121636.3183761-1-zhongjinghua@huaweicloud.com>
 <d119fcba-a323-d0cd-0d36-759ad2fb8252@acm.org>
From:   zhongjinghua <zhongjinghua@huaweicloud.com>
In-Reply-To: <d119fcba-a323-d0cd-0d36-759ad2fb8252@acm.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Thanks for you adevice.

Jinghua

在 2023/3/8 6:35, Bart Van Assche 写道:
> On 3/6/23 04:16, Zhong Jinghua wrote:
>> +            /*
>> +             * If the reference count is already zero, skip this
>> +             * target is safe  because scsi_target_destroy()
>> +             * will wait until the host lock has been released
>> +             * before freeing starget.
>> +             */
>
> The above comment has grammatical issues and is confusing. I think the 
> comment that I suggested was much better than the above.
>
> Bart.
>