MIME-Version: 1.0
References: <20230307130332.53029-1-daniel.almeida@collabora.com> <20230307164603.686281dc.gary@garyguo.net>
In-Reply-To: <20230307164603.686281dc.gary@garyguo.net>
From:   Wedson Almeida Filho <wedsonaf@gmail.com>
Date:   Wed, 8 Mar 2023 01:08:00 -0300
Message-ID: <CANeycqoV9aDsh5aYynxGwah0=WVgboKQsTVQHJdSFwougRKqYA@mail.gmail.com>
Subject: Re: [PATCH] rust: virtio: add virtio support
To:     Gary Guo <gary@garyguo.net>
Cc:     Daniel Almeida <daniel.almeida@collabora.com>, ojeda@kernel.org,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, kernel@collabora.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 7 Mar 2023 at 13:46, Gary Guo <gary@garyguo.net> wrote:
>
> On Tue,  7 Mar 2023 10:03:32 -0300
> Daniel Almeida <daniel.almeida@collabora.com> wrote:
>
> > This patch adds virtIO support to the rust crate. This includes the
> > capability to create a virtIO driver (through the module_virtio_driver
> > macro and the respective Driver trait) as well as initial virtqueue
> > support.
> >
> > A sample virtIO module is included for conveninence.
> >
> > Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com>
> > ---
> >
> > Ok so this is my first Rust contribution here. It's part of a virtIO
> > driver I was originally writing. Both the probing and the virtqueue
> > support in here were confirmed as working in said prototype driver, and
> > the pieces were picked separately into this patch.
> >
> > Feel free to point me to the best practices around Rust patch
> > submission, as the C stuff like checkpatch etc probably does not apply
> > yet. I did take care to run clippy though.
>
> Hi Daniel,
>
> This patch seems to be based on top the GitHub rust branch, not the
> rust-next branch.

FWIW, I'll soon send patches for the `driver` module to rust-next,
which should allow bus abstractions such as this to be rebased onto
rust-next as well.