Date:   Wed, 8 Mar 2023 13:15:43 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Len Brown <lenb@kernel.org>,
        Robert Moore <robert.moore@intel.com>
CC:     <linux-acpi@vger.kernel.org>,
        <acpica-devel@lists.linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>,
        Hariganesh Govindarajulu <hariganesh.govindarajulu@intel.com>
Subject: Re: [PATCH v2] ACPI: tools: pfrut: Check if the input of level and
 type is in the right numeric range
Message-ID: <ZAgZ/xlXl59WQLul@chenyu5-mobl1>
References: <20230308130902.18397-1-yu.c.chen@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230308130902.18397-1-yu.c.chen@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?8MEsk8eOgdDGMhLNV63b2PjDCA02BfgmiyQf0kUdwY7B7TIfhT3Z8pk5yk?=
 =?iso-8859-1?Q?GYg56tAuo/9kbHCLpJgTeJlH4WY47bAHec2A/2AoLnGXMIXPBDEGOaJiOE?=
 =?iso-8859-1?Q?xC9j0i37M6poqHgKmp9Vz9uwP3G/NTeW+Tfsx8DIpBXH+Y0gh0peIzn3zY?=
 =?iso-8859-1?Q?zK/AHL5JNipnNqZoiwhcxH8GFy96GZ8O7xW3jczJPjivmIF9uoWVYMN/i4?=
 =?iso-8859-1?Q?ZdLPBxHQTsyIe65BK9DETannm6OgW2k2nxlsPswvBJiGtKvdVW3YA+Z4/k?=
 =?iso-8859-1?Q?fyo2DHSbDoIUpG3rlOqT8z/Xfq1WI6B/XiZFK3Z/raNCDsGpMLAuxkq8Je?=
 =?iso-8859-1?Q?pTstxJ6thAF0rko5HjuFe8QrLlvNqUcFrzdXK/u8tIfTOHzf5sJ7hcSEcg?=
 =?iso-8859-1?Q?o+fg3deMkf7R+ivD3v+SGMnkkik/VdIPNE8AlwMBmddJjD3z9ZfWnIfmeu?=
 =?iso-8859-1?Q?Gh5p4OsXvUaxhmO8ty4QoRVzEILd1EQECsS+snA4GcZU/ac1y9tnnpYi5J?=
 =?iso-8859-1?Q?rJqLU9zCVO9HboOwIXnZFKBtrx0m250abPwdeCQ0RC24MXNn61S25lnODu?=
 =?iso-8859-1?Q?Wfz3R6QIogVVJve7pQRoTd40EiM6jhUZCXc0SJn9v4/bbAm3DsF21+XpnN?=
 =?iso-8859-1?Q?8Tp92ogi8lUOmeFis1BMmy1naGJlM+Uj7gzRhIkMv6UEvIO6Jm8XX/MVJ3?=
 =?iso-8859-1?Q?K1kPOwiQfV3lSix+K+8T0B7Fqsf0zCDlnaxPDOKQorOWI/ppnf3slZnhh8?=
 =?iso-8859-1?Q?PBAMU6NQjq+22yROXlsEApeTxq5t7HSomZstMI184ZlDih3zjZ2Llpc9BB?=
 =?iso-8859-1?Q?2gNeyWe686QkqBUDe5aPDgMkyVihY8s4eifCqgEKmECyDRAaJnt6JsdvPq?=
 =?iso-8859-1?Q?FDtRATorN4fLe2QAoKIW76aMNNcRRykZYAqvJo/OCXSdktL6Y/8NMt2iFX?=
 =?iso-8859-1?Q?hTFEJHUMvCN2yEgn+ml49HPUiDL4G1+/wt4Vbm5NzbN3gagujiraBUZPAq?=
 =?iso-8859-1?Q?2Sn7GJGxnXNSdUgKj4xi2fHxGQpvT8axMBYrscM75ZeSwbKTZCZChHd9C7?=
 =?iso-8859-1?Q?lGnNd+h0VTKIDDAdGG/MUbEBtRG0eKysGB8mFCohcQ+EkGbg7jsSI/E8Vx?=
 =?iso-8859-1?Q?bq/T9tI7xrxCSdB08v877WKJjimIodFCEEGSX6xAnsbk0eGhg5xREcnU98?=
 =?iso-8859-1?Q?/Zn2ZMJOur1ZntmG3YoI9OJ7mJ5qRs0VALQ8BY4q5q15yaamsS6zAModbB?=
 =?iso-8859-1?Q?tzQ7+5o+66n0j/VX2Bfe/qmlIVlf3xWgrn9Xf+gtKWPjeLvn026ZxOg+Va?=
 =?iso-8859-1?Q?DbHd0QxjjBcKGOlylKIdOgVRi8AyoQHZQLwtqitk1zon2h3Y02AWs/VTnx?=
 =?iso-8859-1?Q?WnUvaAcqVaNWiWWQWnnlJ8Xw9nsCgHQgYTXbrpj/ygpo9X6qCzBu3w3jxv?=
 =?iso-8859-1?Q?l/450PweuIg1gbE7LaB83u/iPB2aN0i6LIS5GDWQ3iSFJMXbgHtMIsaVPo?=
 =?iso-8859-1?Q?EZT6RqBxUINnoKFexSa1AjjkzlXphgwCEaw/QMuvrhD3zyMf141tsMfnMr?=
 =?iso-8859-1?Q?Ax1eZiykvjQ90o8AzBswTwY5UyTfyqcpNJKwOF+XKAXErNpz9MGfvI8E2L?=
 =?iso-8859-1?Q?NaQM+sro/kuSzj2Qjz9ksSVJjBfBxqW1mO?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 277930c0-9329-4169-4f58-08db1f9431f8
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 05:15:55.8753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S83bNIBdvhWR9/ODy+vZiSTDpriToL/fuV16xeemigBiD74KAu3wVS2DUhfdlf0nQisYQbMrsxofjc7j/2JAzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5279
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-03-08 at 21:09:02 +0800, Chen Yu wrote:
> The user provides arbitrary non-numeic value to level and type, which could
> bring expected bahavior. In this case the expected behavior would be to throw
> an error.
> 
>  pfrut -h
> usage: pfrut [OPTIONS]
> code injection:
> -l, --load
> -s, --stage
> -a, --activate
> -u, --update [stage and activate]
> -q, --query
> -d, --revid
> update?telemetry:
> -G, --getloginfo
> -T, --type(0:execution, 1:history)
> -L, --level(0, 1, 2, 4)
> -R, --read
> -D, --revid log
> 
>  pfrut -T A
>  pfrut -G
> log_level:0
> log_type:0
> log_revid:2
> max_data_size:65536
> chunk1_size:0
> chunk2_size:1530
> rollover_cnt:0
> reset_cnt:17
> 
> Fix this by restricting the input to be in the expected range.
> 
> Reported-by: Hariganesh Govindarajulu <hariganesh.govindarajulu@intel.com>
> Suggested-by: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
>
Please ignore this version due to broken format, I'll send a new one.
Sorry for the noise.

thanks,
Chenyu