Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D649C64EC4 for ; Wed, 8 Mar 2023 05:40:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229746AbjCHFkO (ORCPT ); Wed, 8 Mar 2023 00:40:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjCHFkL (ORCPT ); Wed, 8 Mar 2023 00:40:11 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECD92974A0 for ; Tue, 7 Mar 2023 21:40:09 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A3E31219CE; Wed, 8 Mar 2023 05:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678254008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SETYpkpQMST49MYA3BJbWtmG/kyTZaprDENnjGclN4M=; b=N/Xyvu55i0lMn43T8vdaknu3x7Dn38FeXrixfhP/EyEb1pllzLflDrrZQM4lFbX1iDG7Lc E6YejEa6SrqMaCD0RKZ0PQEG6NRjNXrVyARFdO2P9YNdvzEsnbsn6QKPupq68HCIdb+ymH ZuLYD2Lpk1F3uoeGXmOiXRS/ddwd0Dc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678254008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SETYpkpQMST49MYA3BJbWtmG/kyTZaprDENnjGclN4M=; b=MsSFLmMgNpHVspljo64fgULCejAWOxbQBM/qRj2sde0MMcqxcR4pZom2sOyrFbrqdcCouV aT6gmM1uKDBnyqCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 792D913596; Wed, 8 Mar 2023 05:40:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dlO0HLgfCGRmQAAAMHmgww (envelope-from ); Wed, 08 Mar 2023 05:40:08 +0000 Date: Wed, 08 Mar 2023 06:40:07 +0100 Message-ID: <87h6uviyx4.wl-tiwai@suse.de> From: Takashi Iwai To: Bjorn Helgaas Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH] ALSA: hda: Match only Intel devices with CONTROLLER_IN_GPU() In-Reply-To: <20230307214054.886721-1-helgaas@kernel.org> References: <20230307214054.886721-1-helgaas@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Mar 2023 22:40:54 +0100, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > CONTROLLER_IN_GPU() is clearly intended to match only Intel devices, but > previously it checked only the PCI Device ID, not the Vendor ID, so it > could match devices from other vendors that happened to use the same Device > ID. > > Update CONTROLLER_IN_GPU() so it matches only Intel devices. > > Fixes: 535115b5ff51 ("ALSA: hda - Abort the probe without i915 binding for HSW/B") > Signed-off-by: Bjorn Helgaas Thanks, applied now. Takashi