MIME-Version: 1.0
References: <20230308011705.291337-1-konrad.dybcio@linaro.org>
In-Reply-To: <20230308011705.291337-1-konrad.dybcio@linaro.org>
From:   Shawn Guo <shawn.guo@linaro.org>
Date:   Wed, 8 Mar 2023 15:24:38 +0800
Message-ID: <CAAQ0ZWSXP59cgyHNkR8UfXRHqRrJGLxuNwMBh2N6=W_x18-BTg@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: interrupt-controller: Allow #power-domain-cells
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     linux-arm-msm@vger.kernel.org, andersson@kernel.org,
        agross@kernel.org, marijn.suijten@somainline.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Mar 8, 2023 at 9:17=E2=80=AFAM Konrad Dybcio <konrad.dybcio@linaro.=
org> wrote:
>
> MPM provides a single genpd. Allow #power-domain-cells =3D <0>.

Indeed! It was missing from the initial submission.  Thanks for fixing it u=
p!

>
> Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM=
 support")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml     | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,=
mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.=
yaml
> index 509d20c091af..4c470dc143e5 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yam=
l
> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yam=
l
> @@ -62,6 +62,9 @@ properties:
>          - description: MPM pin number
>          - description: GIC SPI number for the MPM pin
>
> +  '#power-domain-cells':

Should we add it to the "required" list and examples?

Shawn

> +    const: 0
> +
>  required:
>    - compatible
>    - reg
> --
> 2.39.2
>