Message-ID: <298e8999-6faa-044c-43ef-552d107cff5f@amperemail.onmicrosoft.com>
Date:   Wed, 8 Mar 2023 14:42:49 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH v2] ARM: dts: aspeed: mtmitchell: Enable NCSI
Content-Language: en-US
To:     Joel Stanley <joel@jms.id.au>,
        Chanh Nguyen <chanh@os.amperecomputing.com>
Cc:     OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Jeffery <andrew@aj.id.au>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <20230228102820.18477-1-chanh@os.amperecomputing.com>
 <CACPK8XesuUATxCVEGpus=ZHTkjS=L=gjRHC3V+=XLSofU-WSSw@mail.gmail.com>
From:   Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
In-Reply-To: <CACPK8XesuUATxCVEGpus=ZHTkjS=L=gjRHC3V+=XLSofU-WSSw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFczaGltN2xnMmszbE5oVGpabzdjWkdCbG96YzZNSEp4WThqUE9laGl6bHVU?=
 =?utf-8?B?Y0NhNGpPdmEyQkFzSEdRTG1LckJHditUTGxaV3V3TXR2TnJKcXJzcUFFWHV6?=
 =?utf-8?B?UkNwc2pTaUpHQUhaSW16bDY0bW9CNlRYY2ZlM1FFUXZ5TTVSaDRrMXhLTUsw?=
 =?utf-8?B?M1l3N0kwRUFPcnJlQzM3ckVCMDJiMktQU3R2OXY5MmM5a0s4cDhoQitSS0lH?=
 =?utf-8?B?YTNIalh0N0RGS0U4VVc0RVhtdVovQ2kya2w5dElUZEFMcC9uRjlwcm9ZOVdZ?=
 =?utf-8?B?ZDBUN0ZrZUI4T05RcVNHMTlKMm41TXRCV1gxQXRKVjFDMXpyWUE3KzJHWG1r?=
 =?utf-8?B?b3RqMU5CUW5hM1hmZGdyWUx2MmorVUVSWUlYMTl6ekswNnFmQ2tGMlNOZHJy?=
 =?utf-8?B?NGwvWk1SNFlta3oxbWxOZVM4QjVENnFkRjZiaXZjVXJERC9uRXNLY05kNnlN?=
 =?utf-8?B?WXFPTVgwWTZmWGJybDRBTGQwcVU1dHZaaDgxbDVTQWh6L0J3NmFKNzZwOVRh?=
 =?utf-8?B?eDEzL0RCaVpiRGhNVmNXa0dWWXBONGxMWXVTVjNjVVRMc0NRYkZ1Nm83a0cr?=
 =?utf-8?B?SDQ1MytCS0dtZm9kUWx0M0dFRUdINUxUUVNqdzFpM0R5WGZwNERMazViZnRC?=
 =?utf-8?B?M0pRYVduLzBsbVAyaE01TmxGbjc4b2xjUk81d1NxdWY2ZUFHcTVKYjdLV3ls?=
 =?utf-8?B?MkpqVDlwTkY3SXVaRHczcjRzNXJXbnJtVWhYbUdRVHdTRUlmajNoWkVvWGwy?=
 =?utf-8?B?a21keEJiR002YWFwODdIWHJLQkh1VklkT09RTVRGMzQ3b3MxWkhjRXl1Ym9R?=
 =?utf-8?B?TG9VVVZaT283alZ6NzNnREdRZG1kaC8rbS84SHVrVnBNdW9oWktPby9uN2lN?=
 =?utf-8?B?QTZyRXIzUmJzUUZvVFBqc0dKTmF0RnV2QW9pQzJkRUliTU9kZnE4L2pkcGNj?=
 =?utf-8?B?ZGtwZThjbyt3QmZVWWZvUThlaUUxMDhDMUQrWFlIbWgyU09GR1Bvb3BIRkQx?=
 =?utf-8?B?ZmExM2o2NXBJbnFCTlRCSHJGSDdlaEV4K3NHR1N2aEhHV2RqZFBZRittR3cx?=
 =?utf-8?B?QXZjVTlTTzA3SGFMMkUrSVNGL3VUQUZpVkpiYmFqNWFJNk5FUTZOT1gxcHdu?=
 =?utf-8?B?ck5Va0tOVFBiU3ZrKzA3M05QVVpKUlVTREZXVm9GZWVyaXNzYkJWb2RPZkVG?=
 =?utf-8?B?Rk5palM2L05CcHpwUHhHZ1F3SXo5Zk4vcG1ib0pUT1VoTjQyYmJaZXlqMnUy?=
 =?utf-8?B?QU9jNUlMbTBFMFlObmJZcy91bHFjMk1tQWtXeFlxL3ZZTlpEWU5GUkc3RHRP?=
 =?utf-8?B?emg0S3J3UzI4N2pDQUd0d1R5M05uMGVwczVBZk15Smc1SlJLeHhaWWR1cFRo?=
 =?utf-8?B?YVg0NkV0V1h5cUZXNWtXMW92TTRrd0N0SUNRTi84MkhSS2tVUUlwZzVrV05S?=
 =?utf-8?B?NVphOHFxUEgramtwUUZJQXlMNWd3WEYvc2IzRUMrc05qRS9vNEhHMlkycElX?=
 =?utf-8?B?b0pmVXNNSFMyc09BK090cFkxeXdXRkhCbjN3YVBrOFRlbUR6cG9HQ2hBZjlC?=
 =?utf-8?B?VXBuRWVVMmRNNGZTZCtsemx2cld2RWwza3VHeitUT2FHMzI5U29LTHNkV1Yw?=
 =?utf-8?B?L0pVcHFQd0R1U2U3YitRRUw2ejlRYlZhMXZTRUdHUk9iRmdILzBZRTd1Qkdz?=
 =?utf-8?B?M2k4QlJ4MHNTTXFQb3BPdXlVVENMb203ekFKZHd4anVNekVNSUx6NVFXMUcr?=
 =?utf-8?B?RmZiRCtjZ20yQ2JabXBhK2kxdlY2TjdXL3MzM2czMGtxMmtKRjIzeFVsWFVs?=
 =?utf-8?B?MHErS3BVVGFVMHpnYlZSY1RhcTJxN2JZdjlkVkRYKzFSNUtpcjRqNGlXc0hI?=
 =?utf-8?B?ZXlNZTJxOW9OS29nZmpyNUNVVHZHNW84bngwdnZSVlJaWWVrc2tKcEovVHQw?=
 =?utf-8?B?NmZKMHY0SG56S0Rqamo1bmVPTFJhSGJ1K3VLRlM0Z3Z6R1ludzFBUVpTSnhB?=
 =?utf-8?B?UlBBYVh1SFdlNS9PSHQyb1pFNGIwUXFZK2lKMHp6V09MdEFFUmplaC9xZW50?=
 =?utf-8?B?eXE4dFhCYXR2cXJvS2RtZGxjRFh6RmJtaW1DcEIrYisweTBUUElmMld5Ym1D?=
 =?utf-8?B?dU9mQjh5Z1RVSWpjWGFHZ2lPR0lncndKOFZtMWhvNjN1Sm4vaUdveGE0OTQ3?=
 =?utf-8?Q?qQbR9abAAaohI56PBrYJJa8=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b73fe64-52d5-43b5-6220-08db1fa8be70
X-MS-Exchange-CrossTenant-AuthSource: SN6PR01MB4973.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 07:43:01.9465
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dvBU2DSzHHKp0mPFkVlmoNRncbGVyhEXA2A49ZNT3yWfHjqRelLd/iZ2GGzmYVXokKwYOFKXgdLR3GPI43ocivE2NK/7a0Xp6PT4zzmem1cZ+c9Eu9wpga1gnG3KQktU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5099
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 01/03/2023 07:17, Joel Stanley wrote:
> On Tue, 28 Feb 2023 at 10:28, Chanh Nguyen <chanh@os.amperecomputing.com> wrote:
>>
>> Support the mac3 (RGMII4) as an NC-SI stack instead of an MDIO PHY.
>>
>> The OCP slot #0 and OCP slot #1 use a common the BMC_NCSI signal,
>> so we use only one of them at the same time. The OCP slot #0 will
>> be enabled by PCA9539's setting by default.
>>
>> Also, enable the OCP Auxiliary Power during booting.
>>
>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> 
> LGTM. I'll apply it once we have a -rc1.
> 
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> 

Thank Joel very much!

>> ---
>> Changes in v2:
>>     - Change PCA9539APW node name.                     [Krzysztof]
>> ---
>>   .../boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 37 ++++++++++++++++++-
>>   1 file changed, 36 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> index 4b91600eaf62..1e0e88465254 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> @@ -251,6 +251,14 @@
>>          pinctrl-0 = <&pinctrl_rgmii1_default>;
>>   };
>>
>> +&mac3 {
>> +       status = "okay";
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pinctrl_rmii4_default>;
>> +       clock-names = "MACCLK", "RCLK";
>> +       use-ncsi;
>> +};
>> +
>>   &fmc {
>>          status = "okay";
>>          flash@0 {
>> @@ -439,6 +447,26 @@
>>          status = "okay";
>>   };
>>
>> +&i2c8 {
>> +       status = "okay";
>> +
>> +       gpio@77 {
>> +               compatible = "nxp,pca9539";
>> +               reg = <0x77>;
>> +               gpio-controller;
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               #gpio-cells = <2>;
>> +
>> +               bmc-ocp0-en-hog {
>> +                       gpio-hog;
>> +                       gpios = <7 GPIO_ACTIVE_LOW>;
>> +                       output-high;
>> +                       line-name = "bmc-ocp0-en-n";
>> +               };
>> +       };
>> +};
>> +
>>   &i2c9 {
>>          status = "okay";
>>   };
>> @@ -530,13 +558,20 @@
>>          /*V0-V7*/       "s0-hightemp-n","s0-fault-alert","s0-sys-auth-failure-n",
>>                          "host0-reboot-ack-n","host0-ready","host0-shd-req-n",
>>                          "host0-shd-ack-n","s0-overtemp-n",
>> -       /*W0-W7*/       "ocp-aux-pwren","ocp-main-pwren","ocp-pgood","",
>> +       /*W0-W7*/       "","ocp-main-pwren","ocp-pgood","",
>>                          "bmc-ok","bmc-ready","spi0-program-sel","spi0-backup-sel",
>>          /*X0-X7*/       "i2c-backup-sel","s1-fault-alert","s1-fw-boot-ok",
>>                          "s1-hightemp-n","s0-spi-auth-fail-n","s1-sys-auth-failure-n",
>>                          "s1-overtemp-n","s1-spi-auth-fail-n",
>>          /*Y0-Y7*/       "","","","","","","","host0-special-boot",
>>          /*Z0-Z7*/       "reset-button","ps0-pgood","ps1-pgood","","","","","";
>> +
>> +       ocp-aux-pwren-hog {
>> +               gpio-hog;
>> +               gpios = <ASPEED_GPIO(W, 0) GPIO_ACTIVE_HIGH>;
>> +               output-high;
>> +               line-name = "ocp-aux-pwren";
>> +       };
>>   };
>>
>>   &gpio1 {
>> --
>> 2.17.1
>>