Message-ID: <9858ecfc-6a51-71a9-70e7-dd1e3eb9ba65@linaro.org>
Date:   Wed, 8 Mar 2023 08:45:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] dt-bindings: interrupt-controller: Allow
 #power-domain-cells
Content-Language: en-US
To:     Shawn Guo <shawn.guo@linaro.org>
Cc:     linux-arm-msm@vger.kernel.org, andersson@kernel.org,
        agross@kernel.org, marijn.suijten@somainline.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20230308011705.291337-1-konrad.dybcio@linaro.org>
 <CAAQ0ZWSXP59cgyHNkR8UfXRHqRrJGLxuNwMBh2N6=W_x18-BTg@mail.gmail.com>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <CAAQ0ZWSXP59cgyHNkR8UfXRHqRrJGLxuNwMBh2N6=W_x18-BTg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 8.03.2023 08:24, Shawn Guo wrote:
> On Wed, Mar 8, 2023 at 9:17 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> MPM provides a single genpd. Allow #power-domain-cells = <0>.
> 
> Indeed! It was missing from the initial submission.  Thanks for fixing it up!
> 
>>
>> Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>  .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml     | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
>> index 509d20c091af..4c470dc143e5 100644
>> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
>> @@ -62,6 +62,9 @@ properties:
>>          - description: MPM pin number
>>          - description: GIC SPI number for the MPM pin
>>
>> +  '#power-domain-cells':
> 
> Should we add it to the "required" list and examples?
I was debating it.. it's definitely not *required*, as the
irqchip part works even without it and then on SoCs with MPM
but without PSCI the setup may be tricky..

About the example, both yes/no are okay for me

Konrad
> 
> Shawn
> 
>> +    const: 0
>> +
>>  required:
>>    - compatible
>>    - reg
>> --
>> 2.39.2
>>