MIME-Version: 1.0
References: <20230308083759.11692-1-clamor95@gmail.com> <202303080844360ced8b82@mail.local>
In-Reply-To: <202303080844360ced8b82@mail.local>
From:   Svyatoslav Ryhel <clamor95@gmail.com>
Date:   Wed, 8 Mar 2023 10:46:13 +0200
Message-ID: <CAPVz0n2XErDOCERV+XO3ek4_15hiwTasy4agLZLijqx2z67UnA@mail.gmail.com>
Subject: Re: [PATCH v1] max77663-rtc: pass rtc address from device tree node
 if exists
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Chanwoo Choi <cw00.choi@samsung.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

=D1=81=D1=80, 8 =D0=B1=D0=B5=D1=80. 2023=E2=80=AF=D1=80. =D0=BE 10:44 Alexa=
ndre Belloni
<alexandre.belloni@bootlin.com> =D0=BF=D0=B8=D1=88=D0=B5:
>
> Hello,
>
> the subject is not correct, please use the subsystem style
>
> On 08/03/2023 10:37:59+0200, Svyatoslav Ryhel wrote:
> > MAX77663 PMIC can have RTC on both 0x63 i2c address (like grouper)
> > which is main address but on some devices RTC is located on 0x48
> > i2c address (like p880 and p895 from LG). Lets add property to be
> > able to use alternative address if needed without breaking existing
> > bindings.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > ---
> >  drivers/rtc/rtc-max77686.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
> > index b0250d91fb00..218177375531 100644
> > --- a/drivers/rtc/rtc-max77686.c
> > +++ b/drivers/rtc/rtc-max77686.c
> > @@ -691,6 +691,7 @@ static int max77686_init_rtc_regmap(struct max77686=
_rtc_info *info)
> >  {
> >       struct device *parent =3D info->dev->parent;
> >       struct i2c_client *parent_i2c =3D to_i2c_client(parent);
> > +     int rtc_i2c_addr;
> >       int ret;
> >
> >       if (info->drv_data->rtc_irq_from_platform) {
> > @@ -714,8 +715,13 @@ static int max77686_init_rtc_regmap(struct max7768=
6_rtc_info *info)
> >               goto add_rtc_irq;
> >       }
> >
> > +     ret =3D device_property_read_u32(parent, "maxim,rtc-i2c-address",
> > +                                    &rtc_i2c_addr);
>
> This property needs to be documented
>

max776xx pmic has no yaml to document

> > +     if (ret)
> > +             rtc_i2c_addr =3D info->drv_data->rtc_i2c_addr;
> > +
> >       info->rtc =3D devm_i2c_new_dummy_device(info->dev, parent_i2c->ad=
apter,
> > -                                           info->drv_data->rtc_i2c_add=
r);
> > +                                           rtc_i2c_addr);
> >       if (IS_ERR(info->rtc)) {
> >               dev_err(info->dev, "Failed to allocate I2C device for RTC=
\n");
> >               return PTR_ERR(info->rtc);
> > --
> > 2.37.2
> >
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com