Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760392AbXINMGa (ORCPT ); Fri, 14 Sep 2007 08:06:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757998AbXINMGX (ORCPT ); Fri, 14 Sep 2007 08:06:23 -0400 Received: from mtagate3.de.ibm.com ([195.212.29.152]:52618 "EHLO mtagate3.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753898AbXINMGW (ORCPT ); Fri, 14 Sep 2007 08:06:22 -0400 Date: Fri, 14 Sep 2007 14:06:21 +0200 From: Cornelia Huck To: Greg KH Cc: linux-kernel@vger.kernel.org Subject: Re: sysfs: spit a warning to users when they try to create a duplicate sysfs file Message-ID: <20070914140621.77054e9d@gondolin.boeblingen.de.ibm.com> In-Reply-To: <20070913234118.GH10856@kroah.com> References: <20070913233751.GA10856@kroah.com> <20070913234118.GH10856@kroah.com> Organization: IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Martin Jetter =?ISO-8859-15?Q?Gesch=E4ftsf=FChrung:?= Herbert Kircher Sitz der Gesellschaft: =?ISO-8859-15?Q?B=F6blingen?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.0.0 (GTK+ 2.10.13; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 21 On Thu, 13 Sep 2007 16:41:18 -0700, Greg KH wrote: > int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd) > { > - if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) > + if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) { > + printk(KERN_WARNING, "sysfs: duplicate filename '%s' " Stray ',' here ------------------->^ > + "can not be created\n", sd->s_name); > + WARN_ON(1); > return -EEXIST; > + } > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/