Message-ID: <6a3f9545-1e59-982a-c3c9-8d13a7de448a@os.amperecomputing.com>
Date:   Wed, 8 Mar 2023 14:24:54 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 1/2] PCI/ATS: Add a helper function to configure ATS
 STU of a PF
Content-Language: en-US
To:     linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
        joro@8bytes.org, bhelgaas@google.com, robin.murphy@arm.com,
        will@kernel.org
Cc:     jean-philippe@linaro.org,
        sathyanarayanan.kuppuswamy@linux.intel.com,
        darren@os.amperecomputing.com, scott@os.amperecomputing.com
References: <20230228042137.1941024-1-gankulkarni@os.amperecomputing.com>
 <20230228042137.1941024-2-gankulkarni@os.amperecomputing.com>
From:   Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>
In-Reply-To: <20230228042137.1941024-2-gankulkarni@os.amperecomputing.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDZQTER6blc2Mm54d0ZERW9SdTkzM2dmNHJzdGxrQVQzcXYxZkJuSmhEZjhv?=
 =?utf-8?B?bkRYbFgxcUM0dEc0Nnp6WkRNUUJwSTJXMHNsczQ2QkQyT1g5SENwQlBvNWt5?=
 =?utf-8?B?a084YU9McXdoSEdDRGp6KzEvTjU5VTZ3WllHcDJ4elIvSDh5aXQ1amx6azFE?=
 =?utf-8?B?OE44VUxBUzY4bzZUaW1yc1Q5TGUva0lNQnlNdzFYT0lGTVkvVDFnQ3FhZ0pW?=
 =?utf-8?B?TTU0T093eFVVL0JwdHd4Wms0Q3cvTmJrWG5xNDVhbnhmYXYwUElvMmxVZkpu?=
 =?utf-8?B?Tkttb29OV24waU1rclhpeGE5a2lvOXFVUFJ5dkxDQUlodGJyZGNSSFkrZ1Yv?=
 =?utf-8?B?bGl6cDhtN2dxZVhTMjByMHV6RnFldHk5SS82TTg5UHNRUFV3czRDaGI2MGlj?=
 =?utf-8?B?cVpJSm1wdi9lMUhGa25xbkVkZHZ2Vjl4clRvT2xYbFF3cXRWNHhYOVNXWm1M?=
 =?utf-8?B?TGZlRGVwR1pPWWFCOWtxUWU1cUdwak1XeklUaUN2ZmZKVDNDSEp3WHJIS29J?=
 =?utf-8?B?VjRzSGh2YzVkNzU0a2ExV1BFb3JzcWtkYm9raFBpTC9uWmlhSFhlUUNhYzFL?=
 =?utf-8?B?VTJ0MnIvcXNBZHc3RmlsL0ZVQmd4bVNGbjBxdk52ckVaUTNEbi9jTlYvQzAr?=
 =?utf-8?B?cFErL3o5SWpsamFVZXJ3R0dJSXA4VkhVam4vNzkweHZNN3JjZHIxYlp3dHpH?=
 =?utf-8?B?a09tQUE2L05JTmRLQURsM3ExYmEwczYxbWJLZ0FCM05kTUcwTHdoVmplSG9x?=
 =?utf-8?B?dFZpWTFmSXoySmxRY3hCOEN0SlN4TUtmbVYydE9SZlVWSW9EWFU5YytId3A3?=
 =?utf-8?B?VmVhZW11TWk4ckk5TUJzSXZUdS9ITEhiemk4aTVIWDk2WlhsMDhZMkVQN1B5?=
 =?utf-8?B?Z3VxODRUMlRhMVJ5aEp5ZDdDTkxYdXpsNTBlRTBCOXl4U0FBWjE2c3VSZFll?=
 =?utf-8?B?QVEwdG1KRnhoRmFZY3p4cW1ZanVaTWxZU2lhN1NuME4rQUs5OGRZRThGaHdY?=
 =?utf-8?B?Y3d3RnV3T2czMVNiRVJvUGw4ai8yc1VQSDZWa056bWNhNHdlSFJCVXFYWFM3?=
 =?utf-8?B?cUFySWU1eVA1NDB0R2tKNmdvTllZWmFMN3haSXUyazlaZ0tQbXlCcHRMVVpU?=
 =?utf-8?B?Y05xb1VmTXVGcGtmczBuVkVOZUtkT01XcjRSNElTRTR0dUJXOHFVcTFabDc5?=
 =?utf-8?B?eWovdk5IcE95bDZuWVR0VmtoaXpNQnAxOUo1VmpmYjNtaDVneFl2MkNIdnMw?=
 =?utf-8?B?UkxSYnorbW9xOFNvMUw5RFlKUk1ndWE3M2llREdVWWlWdXZnLzk5V3pUMW1t?=
 =?utf-8?B?ajZTODV6Y25GNTNjNHFRZ01qKzhOdE4zeEREVisyQTZuUEVXWUE0OVVLQzg3?=
 =?utf-8?B?MnFGeDdTR3RveGhLNjBXN0k5alhOcldZdEpuOC9rOUV4VDRMV3VNa3hQUHpK?=
 =?utf-8?B?cE9kQ0ErODlLZ0xqK01JOE9wanlwVjhJMWQveW5NK3YxOGZDaG53bVhHK0V2?=
 =?utf-8?B?b1hpbnhjbFBFZEFKQy9BaDZLUDJOQjFwcTJ3eUtQdFpBZXNzZzlaZTAwaG5V?=
 =?utf-8?B?TUdRbURaU1JyOHFEMnBOb2xxZ0g1R29yOTc3cVY0QVZSRzN4WkYxMkhydGZ3?=
 =?utf-8?B?Um95UENtNFlrSzJBK2VWSHZYVmIyY1lkdlUwNlNTcXBzelpSb0RXWGRia2ZI?=
 =?utf-8?B?bjI5akJYVGRBejlNMFVRZHJlRXN1cmkvcVhuQjQ5bDFtT1BhNWtjUThvZ2lO?=
 =?utf-8?B?bzA0WFUwMkxRcERlUDBTODBjV2dKN2szKzhjMGtPOXhpQVUrekhsNEVySjBU?=
 =?utf-8?B?c0RPRGo1UDVIRmVNeUhmcWM4MnZGWjE5YjdyZjlxTThiWEdHUHZBcnFITkV6?=
 =?utf-8?B?d2FpSFdSVVdYWXZYMWRFTlhVaWVYTlZpWlVSWk5xbVR2VnJjdys3SDh2bWZr?=
 =?utf-8?B?dktIaFFvUS9nd2x5aEt5QXlnV0ZPRlpZUUNIODZCS2tmbUxkekV1VU5maGRh?=
 =?utf-8?B?MUE1NDc5eVVwVm5nV3h6RlkxTHM2djRqY2gyTUlVTlFDanZURHQ0Mi9PRnJS?=
 =?utf-8?B?RlVqaERYemdIUFQ2d0J3UDdjWmV2QzdzUUx6UThycW8xRU5ONm40eGhvQ2Fj?=
 =?utf-8?B?UE9jakZENWhrdWFXOXVjYjFIcC9mSHlmMDl0VXFaQkR0VkhEUk5BMWFic0tF?=
 =?utf-8?Q?m1QtLQH9vmnVdc4UKT9oFCRdH8vEH+SHwkHOERLn/ZQV?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9bcfa3e4-53ed-41f4-d5fb-08db1fb2ce60
X-MS-Exchange-CrossTenant-AuthSource: DM8PR01MB6824.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 08:55:03.1399
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7GPK284qG7nlOzReFuDxwzX3K/fExqQ9sSkhOkeblU/KaHuZqzrXp6QVYcx0sLaphAKK1VUr97SBB8ywAA8JYkuOiWSGztWTqSMIrKGBhnVbSrC69EHqzoPR6QQv88JC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR01MB5428
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Bjorn,

On 28-02-2023 09:51 am, Ganapatrao Kulkarni wrote:
> As per PCI specification (PCI Express Base Specification Revision
> 6.0, Section 10.5) both PF and VFs of a PCI EP are permitted to be enabled
> independently for ATS capability, however the STU(Smallest Translation
> Unit) is shared between PF and VFs. For VFs, it is hardwired to Zero and
> the associated PF's value applies to VFs.
> 
> In the current code, the STU is being configured while enabling the PF ATS.
> Hence, it is not able to enable ATS for VFs, if it is not enabled on the
> associated PF already.
> 
> Adding a function pci_ats_stu_configure(), which can be called to
> configure the STU during PF enumeration.
> Latter enumerations of VFs can successfully enable ATS independently.

Any comments?
> 
> Signed-off-by: Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>
> ---
>   drivers/pci/ats.c       | 33 +++++++++++++++++++++++++++++++--
>   include/linux/pci-ats.h |  3 +++
>   2 files changed, 34 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c
> index f9cc2e10b676..1611bfa1d5da 100644
> --- a/drivers/pci/ats.c
> +++ b/drivers/pci/ats.c
> @@ -46,6 +46,35 @@ bool pci_ats_supported(struct pci_dev *dev)
>   }
>   EXPORT_SYMBOL_GPL(pci_ats_supported);
>   
> +/**
> + * pci_ats_stu_configure - Configure STU of a PF.
> + * @dev: the PCI device
> + * @ps: the IOMMU page shift
> + *
> + * Returns 0 on success, or negative on failure.
> + */
> +int pci_ats_stu_configure(struct pci_dev *dev, int ps)
> +{
> +	u16 ctrl;
> +
> +	if (dev->ats_enabled || dev->is_virtfn)
> +		return 0;
> +
> +	if (!pci_ats_supported(dev))
> +		return -EINVAL;
> +
> +	if (ps < PCI_ATS_MIN_STU)
> +		return -EINVAL;
> +
> +	dev->ats_stu = ps;
> +	pci_read_config_word(dev, dev->ats_cap + PCI_ATS_CTRL, &ctrl);
> +	ctrl |= PCI_ATS_CTRL_STU(dev->ats_stu - PCI_ATS_MIN_STU);
> +	pci_write_config_word(dev, dev->ats_cap + PCI_ATS_CTRL, ctrl);
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL_GPL(pci_ats_stu_configure);
> +
>   /**
>    * pci_enable_ats - enable the ATS capability
>    * @dev: the PCI device
> @@ -68,8 +97,8 @@ int pci_enable_ats(struct pci_dev *dev, int ps)
>   		return -EINVAL;
>   
>   	/*
> -	 * Note that enabling ATS on a VF fails unless it's already enabled
> -	 * with the same STU on the PF.
> +	 * Note that enabling ATS on a VF fails unless it's already
> +	 * configured with the same STU on the PF.
>   	 */
>   	ctrl = PCI_ATS_CTRL_ENABLE;
>   	if (dev->is_virtfn) {
> diff --git a/include/linux/pci-ats.h b/include/linux/pci-ats.h
> index df54cd5b15db..7d62a92aaf23 100644
> --- a/include/linux/pci-ats.h
> +++ b/include/linux/pci-ats.h
> @@ -8,6 +8,7 @@
>   /* Address Translation Service */
>   bool pci_ats_supported(struct pci_dev *dev);
>   int pci_enable_ats(struct pci_dev *dev, int ps);
> +int pci_ats_stu_configure(struct pci_dev *dev, int ps);
>   void pci_disable_ats(struct pci_dev *dev);
>   int pci_ats_queue_depth(struct pci_dev *dev);
>   int pci_ats_page_aligned(struct pci_dev *dev);
> @@ -16,6 +17,8 @@ static inline bool pci_ats_supported(struct pci_dev *d)
>   { return false; }
>   static inline int pci_enable_ats(struct pci_dev *d, int ps)
>   { return -ENODEV; }
> +static inline int pci_ats_stu_configure(struct pci_dev *d, int ps)
> +{ return -ENODEV; }
>   static inline void pci_disable_ats(struct pci_dev *d) { }
>   static inline int pci_ats_queue_depth(struct pci_dev *d)
>   { return -ENODEV; }


Thanks,
Ganapat