Content-Type: multipart/mixed; boundary="------------OQptv0miZd4Qez8ok0nBlcAw"
Message-ID: <6df72872-2829-47ab-552c-7ef8a6470e6f@shopee.com>
Date:   Wed, 8 Mar 2023 17:03:46 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH] mm: remove redundant check in handle_mm_fault
To:     Matthew Wilcox <willy@infradead.org>
Cc:     David Hildenbrand <david@redhat.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20230306024959.131468-1-haifeng.xu@shopee.com>
 <df3997ed-a844-597b-fbb1-154caad78543@redhat.com>
 <354360d5-dce6-a11c-ee61-d41e615bfa05@shopee.com>
 <ZAamFX/hq6Y/iNJb@casper.infradead.org>
From:   Haifeng Xu <haifeng.xu@shopee.com>
In-Reply-To: <ZAamFX/hq6Y/iNJb@casper.infradead.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------OQptv0miZd4Qez8ok0nBlcAw
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2023/3/7 10:48, Matthew Wilcox wrote:
> On Tue, Mar 07, 2023 at 10:36:55AM +0800, Haifeng Xu wrote:
>> On 2023/3/6 21:49, David Hildenbrand wrote:
>>> On 06.03.23 03:49, Haifeng Xu wrote:
>>>> mem_cgroup_oom_synchronize() has checked whether current memcg_in_oom is
>>>> set or not, so remove the check in handle_mm_fault().
>>>
>>> "mem_cgroup_oom_synchronize() will returned immediately if memcg_in_oom is not set, so remove the check from handle_mm_fault()".
>>>
>>> However, that requires now always an indirect function call -- do we care about dropping that optimization?
>>>
>>>
>>
>> If memcg_in_oom is set, we will check it twice, one is from handle_mm_fault(), the other is from mem_cgroup_oom_synchronize(). That seems a bit redundant.
>>
>> if memcg_in_oom is not set, mem_cgroup_oom_synchronize() returns directly. Though it's an indirect function call, but the time spent can be negligible 
>> compare to the whole mm user falut preocess. And that won't cause stack overflow error.
> 
> I suggest you measure it.

test steps:
1) Run command: ./mmap_anon_test(global alloc, so the memcg_in_oom is not set)
2) Calculate the quotient of cost time and page-fault counts, run 10 rounds and average the results.

The test result shows that whether using indirect function call or not, the time spent in user fault
is almost the same, about 2.3ms.
--------------OQptv0miZd4Qez8ok0nBlcAw
Content-Type: text/plain; charset=UTF-8; name="mmap_anon_test.c"
Content-Disposition: attachment; filename="mmap_anon_test.c"
Content-Transfer-Encoding: base64

I2luY2x1ZGUgPHN5cy9tbWFuLmg+CiNpbmNsdWRlIDxzeXMvdHlwZXMuaD4KI2luY2x1ZGUg
PHN5cy90aW1lLmg+CiNpbmNsdWRlIDxpbnR0eXBlcy5oPgojaW5jbHVkZSA8dW5pc3RkLmg+
CiNpbmNsdWRlIDxzdGRsaWIuaD4KI2luY2x1ZGUgPHN0ZGlvLmg+CiNpbmNsdWRlIDxmY250
bC5oPgojaW5jbHVkZSA8Y3R5cGUuaD4KI2luY2x1ZGUgPHN0cmluZy5oPgoKI2RlZmluZSBT
SVpFICgxICogMTAyNCAqIDEwMjQgKiAxMDI0KQojZGVmaW5lIFBBR0VfU0laRSA0MDk2Cgpp
bnQ2NF90IGN1cnJlbnRfdGltZV9tcygpIHsKCXN0cnVjdCB0aW1ldmFsIHRpbWU7CglnZXR0
aW1lb2ZkYXkoJnRpbWUsIE5VTEwpOwoJaW50NjRfdCBzMSA9IChpbnQ2NF90KSh0aW1lLnR2
X3NlYykgKiAxMDAwOwoJaW50NjRfdCBzMiA9ICh0aW1lLnR2X3VzZWMgLyAxMDAwKTsKCXJl
dHVybiBzMSArIHMyOwp9CgppbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJndltdKQp7Cgl2
b2lkICogYnVmOwoJY2hhciAqIHB0cjsKCXNpemVfdCBzaXplID0gU0laRSwgc3RlcCA9IFBB
R0VfU0laRTsKCWludDY0X3Qgc3RhcnQsIGNvc3Q7CgoJYnVmID0gbW1hcChOVUxMLCBzaXpl
LCBQUk9UX1JFQUR8UFJPVF9XUklURSwgTUFQX1NIQVJFRCB8IE1BUF9BTk9OWU1PVVMsIC0x
LCAwKTsKCWlmIChidWYgPT0gIE1BUF9GQUlMRUQpIHsKCQlwcmludGYoIm1tYXAgZmFpbGVk
XG4iKTsKCX0KCglzdGFydCA9IGN1cnJlbnRfdGltZV9tcygpOwoKCWZvcihzaXplX3QgaSA9
IDA7IGkgPCBzaXplOyBpICs9IHN0ZXAgKSB7CgkJcHRyID0gKGNoYXIgKikoYnVmICsgaSk7
CgkJKnB0ciA9ICdhJzsKCX0KCgljb3N0ID0gY3VycmVudF90aW1lX21zKCkgLSBzdGFydDsK
CXByaW50ZigiY29zdDolIiBQUklkNjQgIiBtc1xuIiwgY29zdCk7CgoJbXVubWFwKGJ1Ziwg
c2l6ZSk7CgogICAgICAgIHJldHVybiAwOwp9Cg==

--------------OQptv0miZd4Qez8ok0nBlcAw--