Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC3FC64EC4 for ; Wed, 8 Mar 2023 09:32:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230144AbjCHJcP (ORCPT ); Wed, 8 Mar 2023 04:32:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230111AbjCHJbw (ORCPT ); Wed, 8 Mar 2023 04:31:52 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13F32B854D for ; Wed, 8 Mar 2023 01:31:34 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id a25so63302701edb.0 for ; Wed, 08 Mar 2023 01:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1678267892; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YmxXJHvQxfbDrLAWch03k5xnRMut7MXIx9gMNxn4uhY=; b=OJ+Fshl6p4wQwfjnQ7Wu1DMBjivuuttYpOO2S1744KYFu1VdWDzM2mrbbop/MBibWl nqGh/HVAAipXTKPjazricJRIcgdWKN4zTOAEEqIE1huj8lkVYGyPvBUFpIhY+Mpw9sGT kB19U5+5ugE5oE5FZNbEPqHnOpz9a12nbuUYUZ+1RU9VNO3cZIbEZQz6jm4dEcyJUTIP vJ1Pe129zIOglZgs6sel8ROQuOZkqF4a0oRcA8xA24xM/Zt/+/AiJZmZ2pLbmjdK+lxg G1/q8ufDsCrBPpJfwzeKRsrTPyuHmaY3hi0/JPonrNhP4IHl4DRVoA++5WsyNNflINqu aFtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678267892; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YmxXJHvQxfbDrLAWch03k5xnRMut7MXIx9gMNxn4uhY=; b=3bTNbGImK2bmfw5p0gNRLfuAlDZ6lmMdUDLFqdIyondDlpg4d3r3CoTsOG+d3zweeb ongIg0vYrwG6s1g52cDxStxtJCqUb7mOoAxHLkndQAuYFdW7UG/OaxyI7VQm2mqe6b47 1Pa7fORj6GKb7gvQzEpf/bnBgLXvmZRXUfD750Hf8mwPivQTcdcaBaaB+aOcalyiPCSv DMfWp7pvUveiuPhyp233NqplzK+pyFdY5iROzkECj2MJ2iOrVBXsGjUI8CGPFUM1tOct OYm57ft3gwgxhUzGvaWlFnwd4ArwKuBuXT7y4oaF3YRxNNzlEQYptycRHp6OCBYiWwuW ZQuw== X-Gm-Message-State: AO0yUKUySlGmCF849+WARVyHd2YFXnG6m79L9VIFkipIHTR3XG0K8OkD f86owkRcyiqsszxeMNW8OsuB5g== X-Google-Smtp-Source: AK7set9f9BPCcWpi1PJQqIc99NrzF34rCnuqLJbhNbcxkqwL4pDsGdVSBZfi393m/qGblUav7G30kA== X-Received: by 2002:a05:6402:1291:b0:4ad:66b:84a5 with SMTP id w17-20020a056402129100b004ad066b84a5mr16119629edv.22.1678267892393; Wed, 08 Mar 2023 01:31:32 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id v24-20020a50d598000000b004bfc59042e5sm7858518edi.61.2023.03.08.01.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 01:31:31 -0800 (PST) Date: Wed, 8 Mar 2023 10:31:30 +0100 From: Jiri Pirko To: Po-Hsu Lin Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, idosch@mellanox.com, danieller@mellanox.com, petrm@mellanox.com, shuah@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net Subject: Re: [PATCHv2] selftests: net: devlink_port_split.py: skip test if no suitable device available Message-ID: References: <20230307150030.527726-1-po-hsu.lin@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230307150030.527726-1-po-hsu.lin@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tue, Mar 07, 2023 at 04:00:30PM CET, po-hsu.lin@canonical.com wrote: >The `devlink -j port show` command output may not contain the "flavour" >key, an example from s390x LPAR with Ubuntu 22.10 (5.19.0-37-generic), >iproute2-5.15.0: > {"port":{"pci/0001:00:00.0/1":{"type":"eth","netdev":"ens301"}, > "pci/0001:00:00.0/2":{"type":"eth","netdev":"ens301d1"}, > "pci/0002:00:00.0/1":{"type":"eth","netdev":"ens317"}, > "pci/0002:00:00.0/2":{"type":"eth","netdev":"ens317d1"}}} As Jakub wrote, this is odd. Could you debug if kernel sends the flavour attr and if not why? Also, could you try with most recent kernel?