Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61C41C64EC4 for ; Wed, 8 Mar 2023 10:23:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230395AbjCHKXL (ORCPT ); Wed, 8 Mar 2023 05:23:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229956AbjCHKXH (ORCPT ); Wed, 8 Mar 2023 05:23:07 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86C8883E9 for ; Wed, 8 Mar 2023 02:22:58 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id ay14so59910752edb.11 for ; Wed, 08 Mar 2023 02:22:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678270977; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ANOvCOjcR37YHU0tLH/+xDUx5MoqGm95UD+lp6dowFE=; b=l6wFqk+Gzy82OQVrxAen6MrjYgfZlwIndoLoD11KzR1wpXVQVW64nQKxoouwOCR1uJ nsE1Jz1sJYjAxPpdVOSiKZcqx6I8Ww8JP2VI/+FBV74p12IMrEx9wZZbTAZyJFOTl9OP wDYZApf0Ndcy2rHyyYSuAmL+X1zffkGgRydX2qNzpu9Q6J4yhKHgQluRvYXGGHg6otcl 7mkStY5JNYG6UodrnO/6od4rftuL9fgGa3PLB6TH4aZ4t3uFldboi8Kyr65NnbLPwD2/ C8dGRbSwzLPT4SzBmNR1M6zIgZ/BiuJL10UXZ5LiVvr48ADojz2qcL1AKlX2mkOOQpep YvwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678270977; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ANOvCOjcR37YHU0tLH/+xDUx5MoqGm95UD+lp6dowFE=; b=alXZni174eOtACa4a9jRjkP4DjB0DPBeGDxJsnPYJ885MuBIc8Qk9TpG6kIQotUKQv B4EqUucMw0c4lzNnvDAF4KIPVGojqWiWkY+3jHgpWqquKlH2btc62fiDsK1UM2E6VIFe YZsVqyAkNt+4enQNIjkj7wCGz+ENrl5v8TLp7T5wDspT9smTTCJibVYlI6u1IPml94xb qv2DBYBpjM9DqIQTf3t+e2W4Db5zpVcSunI+EunDMBwiz7Xr1+A0T0vUUgDiQCzAe8vq Aatgn2Caay9fExe7OE7UJyMSUjEQ5B/UtHFnoNQusJMfRlPBD8I2elTMtLuNr/6lo8eG gQTw== X-Gm-Message-State: AO0yUKVM+L2IeSUorI2uBLevzGYfNtYAtPfhdTJhMl0cr6hUxhnpJs1C Fb9qPxogAfQ+lO1e4xxJ2WylUg== X-Google-Smtp-Source: AK7set+KucngWxAK/nbtRhR0yZNXWWWlrTXtUnifJvxvgsmJKY3NVgXSHU9WOCciMZlioLt5STCC+w== X-Received: by 2002:a50:ee18:0:b0:4af:69b8:52af with SMTP id g24-20020a50ee18000000b004af69b852afmr15524679eds.24.1678270976869; Wed, 08 Mar 2023 02:22:56 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:ff33:9b14:bdd2:a3da? ([2a02:810d:15c0:828:ff33:9b14:bdd2:a3da]) by smtp.gmail.com with ESMTPSA id v30-20020a50955e000000b004bf2d58201fsm7983065eda.35.2023.03.08.02.22.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 02:22:56 -0800 (PST) Message-ID: <9cad9f9e-3619-67a4-2f63-bd334b3d88f7@linaro.org> Date: Wed, 8 Mar 2023 11:22:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] nfc: pn533: initialize struct pn533_out_arg properly Content-Language: en-US To: Fedor Pchelkin Cc: Jakub Kicinski , "David S. Miller" , Minsuk Kang , Alexey Khoroshilov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, syzbot+1e608ba4217c96d1952f@syzkaller.appspotmail.com References: <20230306214838.237801-1-pchelkin@ispras.ru> From: Krzysztof Kozlowski In-Reply-To: <20230306214838.237801-1-pchelkin@ispras.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/2023 22:48, Fedor Pchelkin wrote: > struct pn533_out_arg used as a temporary context for out_urb is not > initialized properly. Its uninitialized 'phy' field can be dereferenced in > error cases inside pn533_out_complete() callback function. It causes the > following failure: > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof