Message-ID: <9abef101-3a9b-0bdd-7139-ced7d5e28ebe@suse.cz>
Date:   Wed, 8 Mar 2023 11:59:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate()
Content-Language: en-US
To:     "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Danilo Krummrich <dakr@redhat.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
References: <20230302011035.4928-1-dakr@redhat.com>
 <20230302015242.xi3y53okc4skmonn@revolver>
Cc:     Christoph Hellwig <hch@lst.de>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20230302015242.xi3y53okc4skmonn@revolver>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/2/23 02:52, Liam R. Howlett wrote:
> Thanks for the patch.  This should indeed be exported.
> 
> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

What uses it? Don't we export only things used by in-kernel modules?

> * Danilo Krummrich <dakr@redhat.com> [230301 20:10]:
>> Fix missing EXPORT_SYMBOL_GPL() statement for mas_preallocate().
>>
>> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
>> ---
>>  lib/maple_tree.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
>> index 26e2045d3cda..3bfb8a6f3f6d 100644
>> --- a/lib/maple_tree.c
>> +++ b/lib/maple_tree.c
>> @@ -5733,6 +5733,7 @@ int mas_preallocate(struct ma_state *mas, void *entry, gfp_t gfp)
>>  	mas_reset(mas);
>>  	return ret;
>>  }
>> +EXPORT_SYMBOL_GPL(mas_preallocate);
>>  
>>  /*
>>   * mas_destroy() - destroy a maple state.
>> -- 
>> 2.39.2
>>
>