Date:   Wed, 8 Mar 2023 12:16:43 +0100
From:   Christian Brauner <brauner@kernel.org>
To:     Tobias Klauser <tklauser@distanz.ch>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Andrei Vagin <avagin@gmail.com>,
        Dmitry Safonov <dima@arista.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org, Andrey Vagin <avagin@openvz.org>,
        stable@vger.kernel.org
Subject: Re: [PATCH 1/2] fork: allow CLONE_NEWTIME in clone3 flags
Message-ID: <20230308111643.dfa5zgiumdairdhn@wittgenstein>
References: <20230308105126.10107-1-tklauser@distanz.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230308105126.10107-1-tklauser@distanz.ch>
Precedence: bulk

On Wed, Mar 08, 2023 at 11:51:26AM +0100, Tobias Klauser wrote:
> Currently, calling clone3() with CLONE_NEWTIME in clone_args->flags
> fails with -EINVAL. This is because CLONE_NEWTIME intersects with
> CSIGNAL. However, CSIGNAL was deprecated when clone3 was introduced in
> commit 7f192e3cd316 ("fork: add clone3"), allowing re-use of that part
> of clone flags.
> 
> Fix this by explicitly allowing CLONE_NEWTIME in clone3_args_valid. This
> is also in line with the respective check in check_unshare_flags which
> allow CLONE_NEWTIME for unshare().
> 
> Fixes: 769071ac9f20 ("ns: Introduce Time Namespace")
> Cc: Andrey Vagin <avagin@openvz.org>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: stable@vger.kernel.org
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---

Oh I either forgot or missed that we use a CSIGNAL bit for
CLONE_NEWTIME. Looks good,

Reviewed-by: Christian Brauner <brauner@kernel.org>