Date:   Wed, 08 Mar 2023 13:19:51 +0200
From:   Svyatoslav Ryhel <clamor95@gmail.com>
To:     Guenter Roeck <linux@roeck-us.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     Jean Delvare <jdelvare@suse.com>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, linux-hwmon@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] hwmon: ina2xx: add optional regulator support
User-Agent: K-9 Mail for Android
In-Reply-To: <a1187c2e-122e-36d1-dddd-c7beba282800@roeck-us.net>
References: <20230308094024.14115-1-clamor95@gmail.com> <20230308094024.14115-3-clamor95@gmail.com> <378db0d7-4d5a-a445-3e1a-ee6d8da5a9e2@linaro.org> <CAPVz0n2KgUKi-m+kjvbxq8fA_G0+KNHtkNe4T0UGpmasMjWK2A@mail.gmail.com> <a1187c2e-122e-36d1-dddd-c7beba282800@roeck-us.net>
Message-ID: <70325083-25B9-434F-9F48-9EE7AE28B550@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


8 =D0=B1=D0=B5=D1=80=D0=B5=D0=B7=D0=BD=D1=8F 2023 =D1=80=2E 13:13:18 GMT+0=
2:00, Guenter Roeck <linux@roeck-us=2Enet> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=
=D0=B0=D0=B2(-=D0=BB=D0=B0):
>On 3/8/23 02:35, Svyatoslav Ryhel wrote:
>> =D1=81=D1=80, 8 =D0=B1=D0=B5=D1=80=2E 2023=E2=80=AF=D1=80=2E =D0=BE 12:=
25 Krzysztof Kozlowski
>> <krzysztof=2Ekozlowski@linaro=2Eorg> =D0=BF=D0=B8=D1=88=D0=B5:
>>>=20
>>> On 08/03/2023 10:40, Svyatoslav Ryhel wrote:
>>>> Some devices may need a specific supply provided
>>>> for this sensor to work properly, like p895 does=2E
>>>>=20
>>>> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail=2Ecom>
>>>> ---
>>>>   drivers/hwmon/ina2xx=2Ec | 12 ++++++++++++
>>>>   1 file changed, 12 insertions(+)
>>>>=20
>>>> diff --git a/drivers/hwmon/ina2xx=2Ec b/drivers/hwmon/ina2xx=2Ec
>>>> index 00fc70305a89=2E=2E4a3e2b1bbe8b 100644
>>>> --- a/drivers/hwmon/ina2xx=2Ec
>>>> +++ b/drivers/hwmon/ina2xx=2Ec
>>>> @@ -119,6 +119,7 @@ struct ina2xx_data {
>>>>        long power_lsb_uW;
>>>>        struct mutex config_lock;
>>>>        struct regmap *regmap;
>>>> +     struct regulator *vdd_supply;
>>>>=20
>>>>        const struct attribute_group *groups[INA2XX_MAX_ATTRIBUTE_GROU=
PS];
>>>>   };
>>>> @@ -656,6 +657,17 @@ static int ina2xx_probe(struct i2c_client *clien=
t)
>>>>                return PTR_ERR(data->regmap);
>>>>        }
>>>>=20
>>>> +     data->vdd_supply =3D devm_regulator_get_optional(dev, "vdd");
>>>> +     if (IS_ERR(data->vdd_supply))
>>>> +             return dev_err_probe(dev, PTR_ERR(data->vdd_supply),
>>>> +                                  "failed to get vdd regulator\n");
>>>> +
>>>> +     ret =3D regulator_enable(data->vdd_supply);
>>>> +     if (ret < 0) {
>>>> +             dev_err(dev, "failed to enable vdd power supply\n");
>>>> +             return ret;
>>>=20
>>> And where is disable? On each error path, removal etc=2E
>>>=20
>>=20
>> error path ok, should I create a remove function just to disable the re=
gulator?
>>=20
>Use devm_add_action_or_reset()=2E
>
>Guenter
>

That is good suggestion=2E Thanks!

Best regards,
Svyatoslav R=2E

>>> Best regards,
>>> Krzysztof
>>>=20
>