Date:   Wed, 08 Mar 2023 08:37:48 -0300
From:   Lux Aliaga <they@mint.lgbt>
To:     Johan Hovold <johan@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>
CC:     agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org,
        kishon@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
        bvanassche@acm.org, keescook@chromium.org, tony.luck@intel.com,
        gpiccoli@igalia.com, ~postmarketos/upstreaming@lists.sr.ht,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-scsi@vger.kernel.org, linux-hardening@vger.kernel.org,
        phone-devel@vger.kernel.org, martin.botka@somainline.org,
        marijn.suijten@somainline.org
Subject: Re: [PATCH v7 3/6] phy: qcom-qmp: Add SM6125 UFS PHY support
User-Agent: K-9 Mail for Android
In-Reply-To: <ZAhwTcMZoCQVULQe@hovoldconsulting.com>
References: <20230306170817.3806-1-they@mint.lgbt> <20230306170817.3806-4-they@mint.lgbt> <25c17af5-8f6b-a2c3-dab3-f9bc69711db7@linaro.org> <ZAhrT1ICTQjfdeGq@hovoldconsulting.com> <64ab4061-6a8b-662e-1c7a-99b0da26751c@linaro.org> <ZAhwTcMZoCQVULQe@hovoldconsulting.com>
Message-ID: <DE127158-6956-42E9-B7AE-9687B4ABD6DA@mint.lgbt>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Autocrypt: addr=they@mint.lgbt; keydata=
 mDMEYyUigxYJKwYBBAHaRw8BAQdA4Emr08ZPSL9p/JLdojT2GPRmh6URPjLQf9l/Kf7x5eC0G0x1
 eCBBbGlhZ2EgPHRoZXlAbWludC5sZ2J0PoiTBBMWCgA7FiEEYa2kUv8kbagAwdmwtWyAWWhjdDcF
 AmMlIoMCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQtWyAWWhjdDf/YQD/VfoHtwZa
 OyBStI87Sv3Wdydps+MALWt7RfPA/AVd/i0A/21kQ+Wr6Hrb7Lz43H3+JLTaQk1XGKn7HMvpARdw
 tVYBuDgEYyUigxIKKwYBBAGXVQEFAQEHQJE2MuI8EY9+pcwq9ynsMxCh1J0AGGo7hO2n9EQtOClI
 AwEIB4h4BBgWCgAgFiEEYa2kUv8kbagAwdmwtWyAWWhjdDcFAmMlIoMCGwwACgkQtWyAWWhjdDe+
 xwD/ZtWx58K/+zLhrdO/kjGftMVM+J3mPA5fJxRYC2Ut42ABAKb0aGOEwFS5XvkOwCLUAMqLGjRg
 SDwi1EbSA+iQnkkB
Precedence: bulk


On 8 March 2023 08:23:57 GMT-03:00, Johan Hovold <johan@kernel=2Eorg> wrot=
e:
>On Wed, Mar 08, 2023 at 12:15:39PM +0100, Konrad Dybcio wrote:
>>=20
>>=20
>> On 8=2E03=2E2023 12:02, Johan Hovold wrote:
>> > On Wed, Mar 08, 2023 at 11:09:48AM +0100, Konrad Dybcio wrote:
>> >>
>> >>
>> >> On 6=2E03=2E2023 18:08, Lux Aliaga wrote:
>> >>> The SM6125 UFS PHY is compatible with the one from SM6115=2E Add a
>> >>> compatible for it and modify the config from SM6115 to make them
>> >>> compatible with the SC8280XP binding
>> >>>
>> >>> Signed-off-by: Lux Aliaga <they@mint=2Elgbt>
>> >>> Reviewed-by: Martin Botka <martin=2Ebotka@somainline=2Eorg>
>> >>> ---
>> >>>  drivers/phy/qualcomm/phy-qcom-qmp-ufs=2Ec | 12 ++++++++++++
>> >>>  1 file changed, 12 insertions(+)
>> >>>
>> >>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs=2Ec b/drivers/ph=
y/qualcomm/phy-qcom-qmp-ufs=2Ec
>> >>> index 318eea35b972=2E=2E44c29fdfc551 100644
>> >>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs=2Ec
>> >>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs=2Ec
>> >>> @@ -620,6 +620,13 @@ static const char * const qmp_phy_vreg_l[] =3D=
 {
>> >>>  	"vdda-phy", "vdda-pll",
>> >>>  };
>> >>> =20
>> >>> +static const struct qmp_ufs_offsets qmp_ufs_offsets_v3_660 =3D {
>> >>> +	=2Eserdes		=3D 0,
>> >>> +	=2Epcs		=3D 0xc00,
>> >>> +	=2Etx		=3D 0x400,
>> >>> +	=2Erx		=3D 0x600,
>> >>> +};
>> >>> +
>> >>>  static const struct qmp_ufs_offsets qmp_ufs_offsets_v5 =3D {
>> >>>  	=2Eserdes		=3D 0,
>> >>>  	=2Epcs		=3D 0xc00,
>> >>> @@ -693,6 +700,8 @@ static const struct qmp_phy_cfg sdm845_ufsphy_c=
fg =3D {
>> >>>  static const struct qmp_phy_cfg sm6115_ufsphy_cfg =3D {
>> >>>  	=2Elanes			=3D 1,
>> >>> =20
>> >>> +	=2Eoffsets		=3D &qmp_ufs_offsets_v3_660,
>> >> Will this not trigger OOB r/w for the users of qcom,sm6115-smp-ufs-p=
hy
>> >> which specify the regions separately (old binding style)?
>> >=20
>> > No, that should work fine=2E
>> So do you think the SM6115 binding could be updated too? Or should
>> we keep it as-is for ABI purposes?=2E=2E
>
>They could be and the possibility has been raised=2E I think it may be
>more important to convert the old combo-phy binding (it's on my list,
>but I keep getting preempted), but at some point we can get rid of the
>legacy UFS binding as well=2E
>
>> > But looks like this series needs to be rebased on 6=2E3-rc1 as these
>> > offsets are now already set in mainline=2E
>> =2E=2EOr did you do that already and I can't find it?
>
>It seems a previous version of this patch was merged almost two months
>ago=2E
>
>	9b9e29af984c ("phy: qcom-qmp: Add SM6125 UFS PHY support")
>
>Not sure what failed here=2E
>
>Johan
Yes, but it received some comments regarding using v5 offsets instead of v=
3-660=2E I could spin off this change into a new patch if necessary=2E