Date:   Wed, 8 Mar 2023 12:48:49 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     error27@gmail.com, Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        P Praneesh <quic_ppranees@quicinc.com>,
        Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
        Jeff Johnson <quic_jjohnson@quicinc.com>,
        Bhagavathi Perumal S <quic_bperumal@quicinc.com>,
        Wen Gong <quic_wgong@quicinc.com>, ath12k@lists.infradead.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: ath12k: Add missing unwind goto in
 ath12k_pci_probe()
Message-ID: <ZAh2IeS3TnyllK33@corigine.com>
References: <20230307104706.240119-1-harshit.m.mogalapalli@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230307104706.240119-1-harshit.m.mogalapalli@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YzEr/+hLKzfKQ+RO1dOShHTuiB7xYSr7XGAr7E7DlrHG5LIQxmeLWgL2Asx2?=
 =?us-ascii?Q?x+zwPb0n2yp6EL239HBqQC2Og0kF4xpNBqvxBTE2Ch4FXTCYUJfBHFD1/xLd?=
 =?us-ascii?Q?J/UwBA7C6r6vJtPpTE6gSS6ZaoM2zBBUSaDnGOU133+3QH7mQjYy4Mf4mMgk?=
 =?us-ascii?Q?NwgdTUEFPjYzXHZnwQnsFO7w0bkWK2MTjNPqrPx5cecHZpTGSDhEejV2eK6Q?=
 =?us-ascii?Q?urIsXfpqtspLvIbnnrqaQ4P/P7yoL+8VmLPnkVjmOxSI0FSN8LXBXeveGzl3?=
 =?us-ascii?Q?ZjjR7GZxerIWuGJlEZN3Mmnvo+GOVU3Uc+RTbUN7w/SKb3f19SSIK6xi5ysY?=
 =?us-ascii?Q?xXvZ4iLUqSHb1gCYzUBG3MHdHpBlOV8BaqZziyzUDFzERI6Vl8TubhzXNsD/?=
 =?us-ascii?Q?mUd6NgBP0ziIBVHWQ6fesnXle7tyPvYLvhMcOKriXbfS3VWSMMjBMnE23b+N?=
 =?us-ascii?Q?h0wjj0oV+TNZamdPeAt31jkOBXq+BhGlFNHtq+KJtyMwDKmmjw7ForcG1h6I?=
 =?us-ascii?Q?lCXPfM80QWkQX8CTV9b+K5poABsdSRgZPMOW2EqghBYMxq2dO0+PoRejVKFU?=
 =?us-ascii?Q?XkQiVmW6onPPT628woWlR/3bc7KZcR3+23zQJYqUldftyGpiGMtVR2X+5/K3?=
 =?us-ascii?Q?FsPilYYHcWlAMt1IwbecYBNyRdbqjdmXesxLhSlTyWY6zOwhRmlXXdRbpEBt?=
 =?us-ascii?Q?Q1VeDcoVCX/uxkcuj6JLkJk9oXZ5OYe9WP1cgiAhtTV6Vnc+e9xuorWIVTxm?=
 =?us-ascii?Q?fKnW0hetJKCbNrYUlB+6Xds5ithKAHV3uxurpvgv9gFaPnH88t5DQDy6ksDK?=
 =?us-ascii?Q?sz/LGhy9FAShkPUQvQexqAcHpE/OQjkXZ+AdkTg1LvM/Ir4RHf6Li+1sTVnT?=
 =?us-ascii?Q?9GOxkh8KA8Oax7cckc+gB0gFvkbqqOIlrmPXMEfFmvYdMayWKMcHlZNcks1t?=
 =?us-ascii?Q?FW/LtEHqUZlVS6eWSB97x7cTFWk2qwm+8Jf6aKqrqk/Z6GOb08Ms5PqKVXR9?=
 =?us-ascii?Q?Kk5PHxoKBWWyHFwsGJBO0nAUm4SRP30FAUpwn95q+K0juUtVLA5COSSpONRO?=
 =?us-ascii?Q?A6hJzmdbEBFkao8PcWZLx5ia+EpGst49n2bGtXSIlGwFbG/NV1gTPadKXZLw?=
 =?us-ascii?Q?FpRI4aA0rxiSi7YDGPOz/+7Kl2WKpW6HrYMk25O92zH0C7kNnQ+CI5/voAJI?=
 =?us-ascii?Q?xdTnVSlMeQs1pawNppcTdm7rL3fcGSfOQCmIgsjd9Kpw72zl8BRmMYsSLkxR?=
 =?us-ascii?Q?IiiDW6je5dwqvxzoZq7SossCLvCQDNbmXIQDJufpPDHXM0WLfk3PoBTiNRPi?=
 =?us-ascii?Q?2N0RiIgRxvKrnMKOQOYp7vxB1x8QC8EBKXyqIxB5zE8l8kuZQ2OJxiyxAK5r?=
 =?us-ascii?Q?rFCOtcojIWfJW+E+D4F/S1GtdioFfjjWrwhKFz2oshL9mdwGV/WrPQBBgJr3?=
 =?us-ascii?Q?knOgvxgE0UdKKCDRn+hzJROxqK2f9Ia2w0ubX0VDaAmcF3Ml3EC7+PGKmD6Q?=
 =?us-ascii?Q?iY8eEo7/tlitvdmGRHdy56c4K9svE3scAqp72rP5r+IjZ286OUby1yuubQbn?=
 =?us-ascii?Q?vLNR6DKWRJZ1yuE45cvmI2TfomWCCb4PGVMoYdW4MsK0r3tpfrfsNt1O1wTs?=
 =?us-ascii?Q?cIPdfar8mwjIiZr4NgqCGaEAlwsO978QRwoIP5PXLGgVQs93xQy0CyFQlWy8?=
 =?us-ascii?Q?EB5SUw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0e07788-0f76-4528-8d62-08db1fcb1904
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 11:48:56.3638
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lpWsyds3ZFpKvauQK49S+cbWNt9nc8HuGR84h7a4F/r+8bh5hkyn/ZvhhzMf5O7SISMa8BGWxlqIZMXXZE00xoE5yojmXTuB0SsXV63Q1gQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB6061
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 07, 2023 at 02:47:06AM -0800, Harshit Mogalapalli wrote:
> Smatch Warns:
> 	drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe()
> 	warn: missing unwind goto?
> 
> Store the error value in ret and use correct label with a goto.
> 
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/
> Suggested-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> Only Compile tested, found with Smatch.

Reviewed-by: Simon Horman <simon.horman@corigine.com>