Message-ID: <d410d181-a94b-40e3-5c3c-50625fbb0196@amd.com>
Date:   Wed, 8 Mar 2023 12:53:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v4 1/5] mailbox: zynqmp: fix counts of child nodes
Content-Language: en-US
To:     Tanmay Shah <tanmay.shah@amd.com>, andersson@kernel.org,
        mathieu.poirier@linaro.org, jaswinder.singh@linaro.org,
        ben.levinsky@amd.com, shubhrajyoti.datta@amd.com
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-remoteproc@vger.kernel.org
References: <20230228210216.447373-1-tanmay.shah@amd.com>
 <20230228210216.447373-2-tanmay.shah@amd.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230228210216.447373-2-tanmay.shah@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnhEUFNCNHp1aTYyN3N1c0RHMlA5Z0pqRVdpSk9ETzBPSGl3YVBnYk5XWnE3?=
 =?utf-8?B?NVY5ZTVjdFlPOHpsV3JzTzlWMEwvbk90MmM3Z3dESTJNellCeURkNk5zd0FS?=
 =?utf-8?B?dkRuSWZZODJkZ2s0Qy9WVnZ5bVUwSWpLTkRwQjJVU2Z1c2JGNllPdEZ1VkJ1?=
 =?utf-8?B?VGFVRm1WT2tSSkpyK0FpSStSSFkrUUVQY1k3UkJGcHlQdVV5YXNvZDgveXZw?=
 =?utf-8?B?SU9ROXovS3N2STJweG5OK0dKM0pnWE42SWs2YnhOaGxnUlVlbVlIWUdRc0hx?=
 =?utf-8?B?RFJCWWVLMFFmRERsMTZicXo5QkRoNk9pcHU4V1M2WHNYWjVTT285cXlFaXBl?=
 =?utf-8?B?OTE0UEFPY1BQaUtNdjN6MVNqSTFSMTYyM0ZQTUw3eXlvZEFGbm1ucmhqNUxo?=
 =?utf-8?B?TjVYdzdJQ1U5U2NkR25rM0dvdzhqNXBkSzhmK1VGTTUvK1M0SGlmQitsYnpm?=
 =?utf-8?B?b0hpbzJKY3hHamlRUjN0Vkg3R0FPaDdFNG9jSEtWL1AwSGkwZEMyQUFkYUM2?=
 =?utf-8?B?dVFOSWV0WXhTdGxvcUdla0pQb1RLRWxsQmY5Nk1kL2VLSjJORmhQekRBWkFQ?=
 =?utf-8?B?NUZadVQrY0dtaHVyNUtPeDJLVzJQSGlwcWhPbllBakFMbW52aWcwUmVuZGVD?=
 =?utf-8?B?NWJvVVhMaks4NU9wN05PSFdtQmpleHVUZ3hIaFZyQkFlRTl5ZjF6dzltc1ZV?=
 =?utf-8?B?MU14a0NJYVFNbFJXSEpCZTBITHA2ZUk5Y0h5OHJyRlhSbXpCNVJ0em5ObjNa?=
 =?utf-8?B?SDJTTWhGWFN5bFdudE5rZ3RXZjExRUtPa0NDOWVYNEJoT1krZFFmaXlSWmFh?=
 =?utf-8?B?VTIwaDNLT3BvYjdkeGZRWUJXTkt6cEErZnlmLzh5eWx2L0J3OXlaVWlnVVdw?=
 =?utf-8?B?ZFRuR1ZQMzZBaGRqS2dWZWFPTG52a3dsRDl4TzRtRVJLWHBvN0VyMmVRc0xy?=
 =?utf-8?B?MEJVUTY1amtHTFhiZGJJUURxc3JNeGEwc0RvaU53bXlaTzRRaXRxY1lJWDZC?=
 =?utf-8?B?NFJ4VXlFa0lsQkFBQTQ2UVpGdS84aVoySm0wcXF3azZNNjZ5eEppV21QYlBC?=
 =?utf-8?B?UHY0ZU04OEdweVk4TzVFN0ZleWE3Z3RidkY0dzBWR1Vub2M2clU0UUpWQml0?=
 =?utf-8?B?RUdkbit5YUxuWTFLWGg3bXpFbFhWYzAwVVU5bmwvbFZqdnZGTWxyNFBJcURI?=
 =?utf-8?B?eW5MUi8yMEU1UTRCd1BZaG9Oci9OQ1UvU1Q1US9YRmZpQ2lEeWRFOWd0Q2tZ?=
 =?utf-8?B?ZW9oamRCYm1Od3dTcVJ6bEgrUkxoSVZOU2NOMFYwMWl0ejU3eElDaHQxcENr?=
 =?utf-8?B?eGRmTGllb2tSMGRTeDBHKzJMZFp3QnFDVVQzTktWSVNBODFiZmNNUFVBQVdo?=
 =?utf-8?B?YmRtL1dJTC9SaVRtNlRpY3RRVXJCQzRYRnVEUHh6S0V0bVhqdUFoRWVsVEM3?=
 =?utf-8?B?bkJIK3lGZ3VrdnpYU3hTSnFqaGJWbDhkWVNRKzBBMDQ2R0VFSjErR2RCWWZY?=
 =?utf-8?B?U25zV21aL0ZLM1QvSXJyWTkzeU1SNUlJS21NdTZUMXZEQlAzY2dnQjl6OTNk?=
 =?utf-8?B?ZzFqaTZCMy85dVFZeFJwMDlING9jVUM1cjZoVzkwc280b0IzZHZsdkVnRTF6?=
 =?utf-8?B?S0dEVGF3L28wc3BNRmdGR20wb1ZrVi9zZHhTSE53c29GaEoyKzhOa0xSQW9M?=
 =?utf-8?B?YWpKVGFVQnY2VmQ1ZkJRTVFQRTJZUGxPSlE1dUhXQ1FsOEMwSUJGcFNmS0l0?=
 =?utf-8?B?Z3d5dFBmcXp2cHJEb3NWcWtpeHA4bVZ6bDUvbDF3SGVzaWdrekI5TXI3TTBw?=
 =?utf-8?B?MWpDWFJYWmI3RzJQdGszSzEzU1poRDJtcDRCWVJwaXdUVmNnb2wrdEFZcjdk?=
 =?utf-8?B?MlVpWU5uTEhtcnB4MW9Rd1FUckhiakljSFJuS3NMRFYyeVRpS0dXM01MdUwr?=
 =?utf-8?B?M3hDbmxpVms2Y1U1THhPTkJkdys4aXlUa1dBRFN3aFJHV2pJNml0bUhWWWNa?=
 =?utf-8?B?TG1DVEpvTVl3dnhFOUxZaU92RWNMeDNMZGRZS3BjMnhlemdpalJOdG5ncmZN?=
 =?utf-8?B?YVBsd0N1YjZONkZIbzYzRlFXaEVVS3M3WlFOdkovZ1BlZTJEK3M5TVUrZy84?=
 =?utf-8?Q?jaQR6Pz8wt9g8WDkAxZi3X4Hw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a511ee9-8843-4c7f-59d6-08db1fcbd14d
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 11:54:05.6355
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8xk+hIWMvb8/X9dAyZ829zwqaIzQKnb9A9Gm14BWwFVLdwC/wnoInRwmQSSSZ4JO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6683
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/28/23 22:02, Tanmay Shah wrote:
> If child mailbox node status is disabled it causes
> crash in interrupt handler. Fix this by assigning
> only available child node during driver probe.
> 
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
>   drivers/mailbox/zynqmp-ipi-mailbox.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index 12e004ff1a14..e287ed7a92ce 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -634,7 +634,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
>   	struct zynqmp_ipi_mbox *mbox;
>   	int num_mboxes, ret = -EINVAL;
>   
> -	num_mboxes = of_get_child_count(np);
> +	num_mboxes = of_get_available_child_count(np);
>   	pdata = devm_kzalloc(dev, sizeof(*pdata) + (num_mboxes * sizeof(*mbox)),
>   			     GFP_KERNEL);
>   	if (!pdata)

I think it will be good to also check that num_mboxes is != 0.

M