Message-ID: <d8551cc8-bd5b-a2e0-ca4d-39bcf96d83c3@amd.com>
Date:   Wed, 8 Mar 2023 12:56:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v4 2/5] mailbox: zynqmp: fix IPI isr handling
Content-Language: en-US
To:     Tanmay Shah <tanmay.shah@amd.com>, andersson@kernel.org,
        mathieu.poirier@linaro.org, jaswinder.singh@linaro.org,
        ben.levinsky@amd.com, shubhrajyoti.datta@amd.com
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-remoteproc@vger.kernel.org
References: <20230228210216.447373-1-tanmay.shah@amd.com>
 <20230228210216.447373-3-tanmay.shah@amd.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230228210216.447373-3-tanmay.shah@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVB0c1oxOW43dG1XU2VJUHN3VVdZMlVJQlZ4V3AzeDJDY3pqNFFrcTlkT1Jj?=
 =?utf-8?B?UmFlMnNZL2ZXUFByRU14ekJqaldzZjhqdzFpeEJpVXZjMGVHZ1dtNmpCQ2Mx?=
 =?utf-8?B?NnExRjZMamM1Yk9JS3AvTzZCUWcwRWxSeVRiVkxPTVJLekdCV0FDWFlXak91?=
 =?utf-8?B?S1ZRWkl0UHIxaXFIUXdsOHE1TkxLdXNiMllnR3ZtbHFieUFYQm5pdUtwRWpG?=
 =?utf-8?B?Z0drYUIyN1c1dHJ2SmY3TFdzdjRvLzBCMWgzTmpkYUlGblkyNHBBN3FVcmZs?=
 =?utf-8?B?NXVlOWxORXJnQ0pGdUhFRlFpdk1RUlZQMVlzYjhrSGd2K1dOeFNyUElNK05P?=
 =?utf-8?B?bWdibDdiR015LzQwTXAvRlk1RndXcTB6M1ZwQnhzREF6ZWRscmViT0VaMENC?=
 =?utf-8?B?UWlJNFpGdEhxazZxTndzTUs4NXlyUTJtWTFIZkNOS2txRTV1Wm81cUVUZGpI?=
 =?utf-8?B?OGQ3RUk4dVUzUDZ5WVRWYkFUSkZ2Rzd4ZXJud0dVenNKaWlxWW9SYUxGblRW?=
 =?utf-8?B?TXpCckVIandSSDdoS01qVTdsT0xHV0VMZEk0SFUrdzVleFc3Y0wwcVpudWp0?=
 =?utf-8?B?cmRwVVdpMTdrMU55ckFVb2Ywb3h2M3pRYWJ5V2hneHNXLzl6emhPcGJhc2ZW?=
 =?utf-8?B?Y0dXRmw2bHNuTTJIa2puSis3Q3lPdDRweWVBcVpONzlRSWVvZnF3UGJsSmh2?=
 =?utf-8?B?NHlma3RMMU1oUzMvRkNpUUFOc2VmcVBZZU9NbGNGTXZ3ZHJ1MjFJTXRJRVUr?=
 =?utf-8?B?V3BWT1AzeFpPazBTSlAxQkxQN0hzMlRIUUhrb092ZUNDZkJQR1ZQUUNHdGZM?=
 =?utf-8?B?K3BUOVlCL3FGNVFmY1B3a0xodjkvb21xM0d5Q1NZU1VtM25DeXFENXVhTmlI?=
 =?utf-8?B?bkRid3ppdzdFM00yOWVjWERSeTFOMW0vSWMzZXFmQks5c2lUVnl2Y05JMXlu?=
 =?utf-8?B?MkZOZUtCWlM5WnB1NmlOd0ZUcVUwUXkvSDJEZDVrMEV0bGI5RFY5Y1FuN2JK?=
 =?utf-8?B?enRoVi9kYjlpVUNUbjkxL1F3MTd2N0hWeTNUa0VRdXFCRGpTMEVvWkNJOWxV?=
 =?utf-8?B?dHNGakloa0dmVmNGemM5cUVMRkNhaWpzWDlvRjhZNnVZaUVjbnprUWdBRlVz?=
 =?utf-8?B?eitYdEpkNFFmU1NoWHlqYzlLVEk4dGNyYkZ6VjZhbm1YN0lNZ0EwMExhZDZS?=
 =?utf-8?B?TlZoQ21zMC9yNG9WQzRsME5UcUgrS0NnTHIvQUloWWpQbTY3ZFBYY0hFOE44?=
 =?utf-8?B?OG92WEFIMnJJN0dPMUdROVFSOE9BT2dpNjdjWENvV2dpSXR0MUo0Z0tRUU50?=
 =?utf-8?B?bnlpZDFUaENKZE9QQkNVTzF0bmZLenROM0ptQ3VIUmJJQncvdW0yM0ZzRzNF?=
 =?utf-8?B?MGI3UzVOcVFuRkRCZW44OXBnUWV4dkNWUFBqeWVNM21zcVZvdWhTalJWYjRL?=
 =?utf-8?B?aExSck5laGVHak5LMkhBbldzdThJdkNTR2Q2b3dyZXF4UjJpQlZSeGZkbzFS?=
 =?utf-8?B?TEZxcjA4Rk1TWmI5ektnTWhNOVJ4WmlCSlNJMm51V25UU0kzaENpL1NaNy85?=
 =?utf-8?B?cU5VdHVXd2lOVEY0ZGZld1BwM3NyWWZTUzZpR25aRWRQRkZKNk56Y0FBY0ky?=
 =?utf-8?B?T2RleHhVb1FCOVl0dDdJaTNlL2JwZnV5Sk00TGs2Si8xZEpWZXlmdFBrLyt3?=
 =?utf-8?B?WmUyQ2lKU2U5YWV2TlAwMXNzODdXRnFsbXk2RG9yVXpSZm15WGFBSXZKazJD?=
 =?utf-8?B?TkxLMWVSWllsRG5XZTllcVZuOERPVW53RXg4cFlGSTZWR1lvUkNGSzdIVnUx?=
 =?utf-8?B?a0lmd3FIV1hVUi9iS1AxUjhiZ1JkbnlVOS9sbW5HTzZXUDBTZU5VaXJPTW9W?=
 =?utf-8?B?bDJCWE9VYy9UaVdWU2hJUVZYZzdjaklwK01SQzJPNmVpU1l4bTFsZ29qWTh0?=
 =?utf-8?B?ZlBPSFdrT1VqU1BHZ0R2RWlDcWFHRE1SZHNhdGNXdWt5Z0ZzWDNCUWNEL3pP?=
 =?utf-8?B?K0dBZlpVOWFhaGFPeFJlWE9LK3hKMW5iSjhJQ1B1c2ZHWkpzN2I5dEJsSlBp?=
 =?utf-8?B?aW12dmJpL3BCVEZFVjRFZnJPUXlNdExabWI3d3ozbDBEWmhNbzBUM3FjRWRH?=
 =?utf-8?Q?e9Nj9gNc55Vh7r2L5uJ80qxId?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfc35b0e-1c12-4aea-cb60-08db1fcc287e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 11:56:31.7963
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bEXcmujdVA9A+eoFyoB1BAmnf5rp0rCkk1FakzkWOJmYWE6g00XTk7bxBScGUwlS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6683
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/28/23 22:02, Tanmay Shah wrote:
> Multiple IPI channels are mapped to same interrupt handler.
> Current isr implementation handles only one channel per isr.
> Fix this behavior by checking isr status bit of all child
> mailbox nodes.
> 
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
>   drivers/mailbox/zynqmp-ipi-mailbox.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index e287ed7a92ce..b1498f6f06e1 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -152,7 +152,7 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data)
>   	struct zynqmp_ipi_message *msg;
>   	u64 arg0, arg3;
>   	struct arm_smccc_res res;
> -	int ret, i;
> +	int ret, i, status = IRQ_NONE;
>   
>   	(void)irq;
>   	arg0 = SMC_IPI_MAILBOX_STATUS_ENQUIRY;
> @@ -170,11 +170,11 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data)
>   				memcpy_fromio(msg->data, mchan->req_buf,
>   					      msg->len);
>   				mbox_chan_received_data(chan, (void *)msg);
> -				return IRQ_HANDLED;
> +				status = IRQ_HANDLED;
>   			}
>   		}
>   	}
> -	return IRQ_NONE;
> +	return status;
>   }
>   
>   /**

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal