Message-ID: <07e64710-6b91-9da6-f483-03706b7ea95a@linaro.org>
Date:   Wed, 8 Mar 2023 14:00:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v1 17/25] arm64: dts: colibri-imx8x: eval: Add spi-to-can
Content-Language: en-US
To:     Philippe Schenker <dev@pschenker.ch>, devicetree@vger.kernel.org,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>
Cc:     NXP Linux Team <linux-imx@nxp.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Frank Rowand <frowand.list@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        Fabio Estevam <festevam@gmail.com>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        linux-kernel@vger.kernel.org
References: <20230308125300.58244-1-dev@pschenker.ch>
 <20230308125300.58244-18-dev@pschenker.ch>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230308125300.58244-18-dev@pschenker.ch>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/03/2023 13:52, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
> 
> Add mcp2515 spi-to-can to &lpspi2.
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> ---
> 
>  .../dts/freescale/imx8x-colibri-eval-v3.dtsi  | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
> index 625d2caaf5d1..e7e3cf462408 100644
> --- a/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi

There is no such file.

> @@ -11,6 +11,13 @@ aliases {
>  		rtc1 = &rtc;
>  	};
>  
> +	/* fixed crystal dedicated to mcp25xx */
> +	clk16m: clock-16mhz-fixed {

Drop "fixed".

> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <16000000>;
> +	};
> +
>  	gpio-keys {
>  		compatible = "gpio-keys";
>  		pinctrl-names = "default";
> @@ -44,6 +51,18 @@ rtc_i2c: rtc@68 {
>  /* Colibri SPI */
>  &lpspi2 {
>  	status = "okay";
> +
> +	mcp2515: can@0 {
> +		compatible = "microchip,mcp2515";
> +		reg = <0>;
> +		interrupt-parent = <&lsio_gpio3>;
> +		interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> +		pinctrl-0 = <&pinctrl_can_int>;
> +		pinctrl-names = "default";
> +		clocks = <&clk16m>;

You just sorted all nodes in previous patches and add something
unsorted? What is then the style of order? Random name?

> +		spi-max-frequency = <10000000>;
> +		status = "okay";

Why do you need it?

> +	};
>  };
>  
>  /* Colibri UART_B */

Best regards,
Krzysztof