Message-ID: <1c9e15e5-b88b-2fbc-7671-1f93d3ef50c6@linaro.org>
Date:   Wed, 8 Mar 2023 13:08:54 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] firmware: xilinx: nvmem: zynqmp: make modular
Content-Language: en-US
To:     Nick Alcock <nick.alcock@oracle.com>, michal.simek@xilinx.com
Cc:     Michal Simek <michal.simek@amd.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
        linux-arm-kernel@lists.infradead.org
References: <20230308122703.114549-1-nick.alcock@oracle.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <20230308122703.114549-1-nick.alcock@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 08/03/2023 12:27, Nick Alcock wrote:
> This driver has a MODULE_LICENSE but is not tristate so cannot be
> built as a module, unlike all its peers: make it modular to match.
> 
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Michal Simek <michal.simek@amd.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---

Thanks for fixing this,

Applied thanks,

--srini
>   drivers/nvmem/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> How's this?  (This supplants the previous patch, obviously.)
> 
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 6dec38805041b..3b3832f4dfad1 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -368,7 +368,7 @@ config NVMEM_VF610_OCOTP
>   	  be called nvmem-vf610-ocotp.
>   
>   config NVMEM_ZYNQMP
> -	bool "Xilinx ZYNQMP SoC nvmem firmware support"
> +	tristate "Xilinx ZYNQMP SoC nvmem firmware support"
>   	depends on ARCH_ZYNQMP
>   	help
>   	  This is a driver to access hardware related data like