Message-ID: <1a837bec-8658-3200-edff-76809de3fae6@linaro.org>
Date:   Wed, 8 Mar 2023 15:34:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v1 17/25] arm64: dts: colibri-imx8x: eval: Add spi-to-can
Content-Language: en-US
To:     dev@pschenker.ch, devicetree@vger.kernel.org,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>
Cc:     NXP Linux Team <linux-imx@nxp.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Frank Rowand <frowand.list@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        Fabio Estevam <festevam@gmail.com>,
        linux-kernel@vger.kernel.org
References: <20230308125300.58244-1-dev@pschenker.ch>
 <20230308125300.58244-18-dev@pschenker.ch>
 <07e64710-6b91-9da6-f483-03706b7ea95a@linaro.org>
 <3730a506119804b5740854c74d1558010ce37b47.camel@pschenker.ch>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <3730a506119804b5740854c74d1558010ce37b47.camel@pschenker.ch>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 08/03/2023 14:43, Philippe Schenker wrote:
>>> +       mcp2515: can@0 {
>>> +               compatible = "microchip,mcp2515";
>>> +               reg = <0>;
>>> +               interrupt-parent = <&lsio_gpio3>;
>>> +               interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
>>> +               pinctrl-0 = <&pinctrl_can_int>;
>>> +               pinctrl-names = "default";
>>> +               clocks = <&clk16m>;
>>
>> You just sorted all nodes in previous patches and add something
>> unsorted? What is then the style of order? Random name?
> 
> My logic behind this one is
> 
> 1. compatible property
> 2. reg property
> 3. standard properties 
>    - first interrupt
>    - then pinctrl
> 4. specific properties
>    - again alphabetically: clocks, spi-max-frequency

clocks and spi-max-frequency are standard properties.

BTW, what is a specific property?

Best regards,
Krzysztof