Message-ID: <324af2b0a763824bef5764ba89545db8bb7f1639.camel@pschenker.ch>
Subject: Re: [PATCH v1 01/25] arm64: dts: colibri-imx8x: Prepare for qxp and
 dx variants
From:   Philippe Schenker <dev@pschenker.ch>
Reply-To: dev@pschenker.ch
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        devicetree@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>
Cc:     NXP Linux Team <linux-imx@nxp.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Frank Rowand <frowand.list@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        Fabio Estevam <festevam@gmail.com>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        linux-kernel@vger.kernel.org
Date:   Wed, 08 Mar 2023 16:21:07 +0100
In-Reply-To: <efe2d0a5-7e4a-c4ff-0bcc-c7e64f5538d3@linaro.org>
References: <20230308125300.58244-1-dev@pschenker.ch>
         <20230308125300.58244-2-dev@pschenker.ch>
         <efe2d0a5-7e4a-c4ff-0bcc-c7e64f5538d3@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-03-08 at 15:33 +0100, Krzysztof Kozlowski wrote:
> On 08/03/2023 13:52, Philippe Schenker wrote:
> > From: Philippe Schenker <philippe.schenker@toradex.com>
>=20
> Subject: Split? Or Rename? Because prepare is too vague.
>=20
> >=20
> > Toradex sells the Colibri iMX8X module in variants with the i.MX
> > 8QXP
> > and i.MX8DX SoC. Prepare for this by moving majority of stuff from
> > imx8qxp-colibri.dtsi into imx8x-colibri.dtsi.
> >=20
> > Remove DX from the model string.
> >=20
> > This commit intends no functional change.
> >=20
> > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> > ---
> >=20
> > =C2=A0.../dts/freescale/imx8qxp-colibri-eval-v3.dts |=C2=A0=C2=A0 4 +-
> > =C2=A0.../boot/dts/freescale/imx8qxp-colibri.dtsi=C2=A0=C2=A0 | 590 +--=
------------
> > --
> > =C2=A0...val-v3.dtsi =3D> imx8x-colibri-eval-v3.dtsi} |=C2=A0=C2=A0 0
> > =C2=A0.../boot/dts/freescale/imx8x-colibri.dtsi=C2=A0=C2=A0=C2=A0=C2=A0=
 | 593
> > ++++++++++++++++++
>=20
> Use proper -B/-C/-M settings so copy will be detected. It's not
> possible
> to review it otherwise.

Thank you! I wasn't aware of these options. They look nice, will try to
make look it better in v2!
>=20
>=20
>=20
> Best regards,
> Krzysztof
>=20