Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B261C6FD1E for ; Wed, 8 Mar 2023 15:29:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231971AbjCHP32 (ORCPT ); Wed, 8 Mar 2023 10:29:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231661AbjCHP3Z (ORCPT ); Wed, 8 Mar 2023 10:29:25 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0AC57BA26 for ; Wed, 8 Mar 2023 07:29:18 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 89A1467373; Wed, 8 Mar 2023 16:29:13 +0100 (CET) Date: Wed, 8 Mar 2023 16:29:13 +0100 From: Christoph Hellwig To: Danilo Krummrich Cc: Christoph Hellwig , Vlastimil Babka , "Liam R. Howlett" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate() Message-ID: <20230308152913.GA19628@lst.de> References: <20230302011035.4928-1-dakr@redhat.com> <20230302015242.xi3y53okc4skmonn@revolver> <9abef101-3a9b-0bdd-7139-ced7d5e28ebe@suse.cz> <20230308144343.GA16259@lst.de> <59b703ac-9660-a0e5-09f7-c5b69d4f39cb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59b703ac-9660-a0e5-09f7-c5b69d4f39cb@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 08, 2023 at 04:18:55PM +0100, Danilo Krummrich wrote: > Consistency wise I think we should either also export mas_preallocate() or > don't export the other ones either. Please send a patch to drop all unused exports.