Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1CB5C64EC4 for ; Wed, 8 Mar 2023 15:31:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232110AbjCHPbk (ORCPT ); Wed, 8 Mar 2023 10:31:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232089AbjCHPbi (ORCPT ); Wed, 8 Mar 2023 10:31:38 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 979CED08D0; Wed, 8 Mar 2023 07:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678289490; x=1709825490; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=5gdnudn/ORBX5pb147Qfuy7AMOqdUXerFXJlV2oV3aU=; b=jyDFmznS7FCCLKjgyDEUPYPNGgPBy/BUKQVaL6KKheUVS5Epl3RniQQR fcWjxQ1mfXxb70HHj7VJLT1xO+9IPGfEpISL1FWc3IuKC2T+KUrlFF2EH 0ykXplIt8aei0YS2ddxHfLlXzluS8btYbs4pc36s0Od1BYZhK+fhrjodH qICWIz5elUN1/VTZo4lP9VP/4lrL52KVZQfLRTx/o4ufXX5rF33Nmfc58 noyzpvmFwSZVU31KCzq80IG4G87VvnJfVJ7SsB7YZMEikZ2rbb42uMP3r Qy/pJwbKVDx+VAQTaDWKpH6ylo86tjgyjC0RwywJ9bhmWBzcFmN4r3DAz Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="315841248" X-IronPort-AV: E=Sophos;i="5.98,244,1673942400"; d="scan'208";a="315841248" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2023 07:31:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="922820519" X-IronPort-AV: E=Sophos;i="5.98,244,1673942400"; d="scan'208";a="922820519" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 08 Mar 2023 07:31:12 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pZvkz-00HUKr-10; Wed, 08 Mar 2023 17:31:09 +0200 Date: Wed, 8 Mar 2023 17:31:08 +0200 From: Andy Shevchenko To: Pin-yen Lin Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck , Xin Ji , Javier Martinez Canillas , Lyude Paul , linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , chrome-platform@lists.linux.dev, =?iso-8859-1?Q?N=EDcolas_F_=2E_R_=2E_A_=2E?= Prado , Marek Vasut , Hsin-Yi Wang , devicetree@vger.kernel.org, Allen Chen , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Stephen Boyd , linux-acpi@vger.kernel.org Subject: Re: [PATCH v13 10/10] drm/bridge: it6505: Register Type C mode switches Message-ID: References: <20230303143350.815623-1-treapking@chromium.org> <20230303143350.815623-11-treapking@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 08, 2023 at 09:51:19PM +0800, Pin-yen Lin wrote: > On Mon, Mar 6, 2023 at 8:03 PM Andy Shevchenko > wrote: > > On Fri, Mar 03, 2023 at 10:33:50PM +0800, Pin-yen Lin wrote: ... > > > + it6505->port_data[i].lane_swap = (dp_lanes[0] / 2 == 1); > > > > ' % 2 == 0' ? > > > Per another patch, I'll update this into `< 2` But here it should be >= 2 then, no? -- With Best Regards, Andy Shevchenko