Date:   Wed, 8 Mar 2023 17:37:53 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: ar71: include linux/gpio/driver.h
Message-ID: <ZAir0b1aPYQdyNRm@smile.fi.intel.com>
References: <20230308145303.826942-1-arnd@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230308145303.826942-1-arnd@kernel.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Mar 08, 2023 at 03:52:53PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The change to remove the implicit gpio/driver.h include was done
> after fixing all the other users, but the ar7 file still needs
> the same change.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thank you!

P.S. Bart, I believe the best strategy here is to you directly apply this to
GPIO tree. If anyone needs this, you can make an immutable tag or branch with
it being included.

Alternatively I can take it and issue a new immutable tag.

Tell me which way suits you better.

> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/mips/ar7/gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/ar7/gpio.c b/arch/mips/ar7/gpio.c
> index ae0e01b9438f..4ed833b9cc2f 100644
> --- a/arch/mips/ar7/gpio.c
> +++ b/arch/mips/ar7/gpio.c
> @@ -7,7 +7,7 @@
>  
>  #include <linux/init.h>
>  #include <linux/export.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
>  
>  #include <asm/mach-ar7/ar7.h>
>  
> -- 
> 2.39.2
> 

-- 
With Best Regards,
Andy Shevchenko