MIME-Version: 1.0
References: <20230308140943.2009970-1-trix@redhat.com>
In-Reply-To: <20230308140943.2009970-1-trix@redhat.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Wed, 8 Mar 2023 10:39:47 -0500
Message-ID: <CADnq5_PdEGjvc59HjaYdffrNmAfFWuVe5M23wenHZMyF9LdCOA@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: remove unused variable res_pool
To:     Tom Rix <trix@redhat.com>
Cc:     harry.wentland@amd.com, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, lyude@redhat.com, Wayne.Lin@amd.com,
        hersenxs.wu@amd.com, hamza.mahfooz@amd.com, Jerry.Zuo@amd.com,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Wed, Mar 8, 2023 at 9:10 AM Tom Rix <trix@redhat.com> wrote:
>
> With gcc and W=3D1, there is this error
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:121=
4:31:
>   error: variable =E2=80=98res_pool=E2=80=99 set but not used [-Werror=3D=
unused-but-set-variable]
>  1214 |         struct resource_pool *res_pool;
>       |                               ^~~~~~~~
>
> Since res_pool is unused, remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c =
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 2739bef9b90c..4b9b5e4050fc 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -1211,7 +1211,6 @@ static int pre_compute_mst_dsc_configs_for_state(st=
ruct drm_atomic_state *state,
>         bool computed_streams[MAX_PIPES];
>         struct amdgpu_dm_connector *aconnector;
>         struct drm_dp_mst_topology_mgr *mst_mgr;
> -       struct resource_pool *res_pool;
>         int link_vars_start_index =3D 0;
>         int ret =3D 0;
>
> @@ -1220,7 +1219,6 @@ static int pre_compute_mst_dsc_configs_for_state(st=
ruct drm_atomic_state *state,
>
>         for (i =3D 0; i < dc_state->stream_count; i++) {
>                 stream =3D dc_state->streams[i];
> -               res_pool =3D stream->ctx->dc->res_pool;
>
>                 if (stream->signal !=3D SIGNAL_TYPE_DISPLAY_PORT_MST)
>                         continue;
> --
> 2.27.0
>