MIME-Version: 1.0
References: <20230308141057.2010361-1-trix@redhat.com>
In-Reply-To: <20230308141057.2010361-1-trix@redhat.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Wed, 8 Mar 2023 10:40:46 -0500
Message-ID: <CADnq5_PtFqWKvVePq+jydpC06QG35q420-9iQErv6OcgYcPzJQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: remove unused variable available
To:     Tom Rix <trix@redhat.com>
Cc:     harry.wentland@amd.com, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, wenjing.liu@amd.com, qingqing.zhuo@amd.com,
        Jun.Lei@amd.com, mghaddar@amd.com, candice.li@amd.com,
        aric.cyr@amd.com, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Wed, Mar 8, 2023 at 9:11 AM Tom Rix <trix@redhat.com> wrote:
>
> With gcc and W=3D1, there is this error
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_dpia_bw.c=
:297:13: error:
>   variable =E2=80=98available=E2=80=99 set but not used [-Werror=3Dunused=
-but-set-variable]
>   297 |         int available =3D 0;
>       |             ^~~~~~~~~
>
> Since available is unused, remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  .../drm/amd/display/dc/link/protocols/link_dp_dpia_bw.c   | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_dpia_b=
w.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_dpia_bw.c
> index f14217cc16fd..2f0311c42f90 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_dpia_bw.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_dpia_bw.c
> @@ -294,7 +294,6 @@ bool link_dp_dpia_set_dptx_usb4_bw_alloc_support(stru=
ct dc_link *link)
>  void dpia_handle_bw_alloc_response(struct dc_link *link, uint8_t bw, uin=
t8_t result)
>  {
>         int bw_needed =3D 0;
> -       int available =3D 0;
>         int estimated =3D 0;
>         int host_router_total_estimated_bw =3D 0;
>
> @@ -373,20 +372,13 @@ void dpia_handle_bw_alloc_response(struct dc_link *=
link, uint8_t bw, uint8_t res
>
>                 // 1. If due to unplug of other sink
>                 if (estimated =3D=3D host_router_total_estimated_bw) {
> -
>                         // First update the estimated & max_bw fields
>                         if (link->dpia_bw_alloc_config.estimated_bw < est=
imated) {
> -                               available =3D estimated - link->dpia_bw_a=
lloc_config.estimated_bw;
>                                 link->dpia_bw_alloc_config.estimated_bw =
=3D estimated;
>                         }
>                 }
>                 // 2. If due to realloc bw btw 2 dpia due to plug OR real=
loc unused Bw
>                 else {
> -
> -                       // We took from another unplugged/problematic sin=
k to give to us
> -                       if (link->dpia_bw_alloc_config.estimated_bw < est=
imated)
> -                               available =3D estimated - link->dpia_bw_a=
lloc_config.estimated_bw;
> -
>                         // We lost estimated bw usually due to plug event=
 of other dpia
>                         link->dpia_bw_alloc_config.estimated_bw =3D estim=
ated;
>                 }
> --
> 2.27.0
>