Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42713C6FD1E for ; Wed, 8 Mar 2023 15:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230473AbjCHPvG (ORCPT ); Wed, 8 Mar 2023 10:51:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232022AbjCHPu4 (ORCPT ); Wed, 8 Mar 2023 10:50:56 -0500 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35539C48A9; Wed, 8 Mar 2023 07:50:47 -0800 (PST) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 328Fogxt002975; Wed, 8 Mar 2023 09:50:42 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1678290642; bh=jzszyWSCpzcY9s0rXEEp290pik8ZDl2g8aFhW2rZxBc=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=UEjgNcE/C2JyEb6BGTtbaxrAryMp1nU4jz1Sm2JZHGPXnq7AeeMmlGbnynkezBw9v jh3gg5FDIXL1uAwhZvUpfdrOt0Oe3b126vgZQxFw7L1BhOaS+oliQ4OeKnzd9Q0hCA W0T67x1RCKlWPDIn7b8wklMUTkQFFtbyZ3qi4OD4= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 328FogP5014225 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 8 Mar 2023 09:50:42 -0600 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 8 Mar 2023 09:50:41 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 8 Mar 2023 09:50:41 -0600 Received: from [128.247.81.39] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 328FofGt007550; Wed, 8 Mar 2023 09:50:41 -0600 Message-ID: <9c705260-c04c-da2e-db9a-df3ddfb69efc@ti.com> Date: Wed, 8 Mar 2023 09:50:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 3/6] gpio: sch311x: Use devm_gpiochip_add_data() to simplify remove path Content-Language: en-US To: Bartosz Golaszewski CC: Peter Tyser , Andy Shevchenko , Linus Walleij , , References: <20230307165432.25484-1-afd@ti.com> <20230307165432.25484-3-afd@ti.com> From: Andrew Davis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/8/23 4:32 AM, Bartosz Golaszewski wrote: > On Wed, Mar 8, 2023 at 11:24 AM Bartosz Golaszewski wrote: >> >> On Tue, Mar 7, 2023 at 5:54 PM Andrew Davis wrote: >>> >>> Use devm version of gpiochip add function to handle removal for us. >>> >>> Signed-off-by: Andrew Davis >>> --- >>> drivers/gpio/gpio-sch311x.c | 25 ++----------------------- >>> 1 file changed, 2 insertions(+), 23 deletions(-) >>> >> >> Applied, thanks! >> >> Bart > > I see there's v2 out, backing it out then. > Looks like I missed something that kernel test robot found, so there will be a v3. Andrew