Message-ID: <ac8fed53-6f05-6ec7-9ef5-61110cd83c0b@amd.com>
Date:   Wed, 8 Mar 2023 11:11:22 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 1/2] drm/vc4: Fix build error with undefined label
Content-Language: en-US
To:     Qingqing Zhuo <qingqing.zhuo@amd.com>,
        amd-gfx@lists.freedesktop.org
References: <20230308093408.239331-1-qingqing.zhuo@amd.com>
Cc:     Emma Anholt <emma@anholt.net>, David Airlie <airlied@gmail.com>,
        Maxime Ripard <mripard@kernel.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230308093408.239331-1-qingqing.zhuo@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVphWmJFajc5UlBwNEtjWWwvUU5rR3MrKytnQXYvM1VDVUhlNmYvNFVOc1RL?=
 =?utf-8?B?OXplRmJPemdmK0huV253N0NKRWVTVCswN3VMd2gweDVmUlAxWVZzVEhtcENH?=
 =?utf-8?B?d3d0U3A3dXJrczg5bGRzOUdYUjBMY0FWNGFMNTJLcXZXOEZDZjlKTzJ2cEdC?=
 =?utf-8?B?NkJVSmk3aEQ3WUx2cFVXOEhyd1N4czlzeEd3WEFIemZSa3lONU1sa2pDMWJx?=
 =?utf-8?B?NVF1aER6QlVZT2ErNmZHNkg5RzhTUjlENWRRdWtncHQvc3cwL3JVRWNBdjNR?=
 =?utf-8?B?Uk9sNmhVNS8vWVAzT3R4Zitkd0NuTnJyOVpYSXR6OTd6YWx4Y1dxQUVLT1A3?=
 =?utf-8?B?aURtN2dDVnhnR2oyVVNnNEJzSTZZb3ZqSVdYTHpBL05rTkc4eFhxQ3lRM29v?=
 =?utf-8?B?dmdzY1JIZVpkOWRlMXhsMktwOXdsZ1ZKOGdTV05IRFgvV0pyK3lTRzRrVEZV?=
 =?utf-8?B?RzhmNTB3U0RrL21wSFhZQ0ZjUXpVN25pWXMvdjJFa1J3U3RQK3JNYlNsZ0F0?=
 =?utf-8?B?QXpvWW5hYTYwUnIzb2pNRVQ0WU9oeEk2ZmhPcVkzMWNwT0ZSampTc0tkVTI3?=
 =?utf-8?B?VjNsdWM0cjl2NWt6ZHdXR3c3QUl4NUNrbDlBRkdmd3padGluc2YrMVNlb2pC?=
 =?utf-8?B?WUdTU1hyRkxqaXJ4c21zZkduZEhOMjhXeU1YQ1lTUlVZVzJ4dVNVZlY2a2xv?=
 =?utf-8?B?QkpmYW9VdHhWOENKNVNGejFQeDNjKzFZaGxDNXlXYmpzRWxnZWdkL29RQjU0?=
 =?utf-8?B?TTIxNHg2b3A0bnZHVTB5NUN1WFR4d0tPaGFqNUJWSWF5Y0tlNkRIamFnVHc3?=
 =?utf-8?B?ZnNZNG9OOUJRWnpYenljNjNCUzZQQWZsa1pWblpUMmZnQlM1SUF0amJXd3Nm?=
 =?utf-8?B?YWlHbzIrb1hTTE5EbFV1OCt2TTVNWU9PZHdIN0I3eHR4ZVZFZFA5REZuQ1dj?=
 =?utf-8?B?SU5xRmx2SFVDL1NCclM0cGJzZG9wcERsM3p2bHRNelFkL1dlc2FFZWFFdyt4?=
 =?utf-8?B?aG9nbUVxVisrNkVabVI2V1JJUHU3NzNQTlp4NTRseDQ0c0hMZDc4ZVZQODRR?=
 =?utf-8?B?QVdaZFpvRjNtN0pZRjlJenhHclZuQ2lKWmMxSVdUWlVtb0YvMVgwVUdWbloy?=
 =?utf-8?B?dEpUMFFyWG9WNFQ4cjQzQzIzMXA4SjU0N3Zlc1F0N2gwbjV1TFJZNGZYU0g4?=
 =?utf-8?B?cVpoQ2pBY2RvQTNBbmZaUVdsT0hhZDgzeEdpcmw2YnhpSHl3Zy9hZ3VBS1R4?=
 =?utf-8?B?aCtDVTcrTC92Y0xDWkt3WHZWWGM0cXdMNFdRTTN5NHBpYVJ4RnBhM0tLNDdF?=
 =?utf-8?B?WEhOQkJlaHZsc2pkUENqQktPcWRkVVVtenc5S0I1cC9CRUUxT3hnRW9wVVpZ?=
 =?utf-8?B?Q20rZVJCZEtWallFL0NYa2NxMk14SzREcVY2dW84YWl4VFVVMnNUQlNEdDZF?=
 =?utf-8?B?ZFFYdDFuMllOd2szeDloZUR1SlFMdkRyblVFbWZDbTUyWE51RDBNaERnVUNO?=
 =?utf-8?B?S05TNjVCK2dTWnZwcUpDcGtmc3BsZHlMYm1zcEZHRXNBRzIvYnZ4ZFdJemdR?=
 =?utf-8?B?MmExckYrZEZlSTQ5cDlyWnBLeW9pYi81ZU1UZFk4dE1WQnB3SG0zKzZVYndN?=
 =?utf-8?B?VlFoV3ArQW1VYWZaVVpCTEtPTTFNK0tGVUYvaW5aWTVGMGpMRERFUFFpbFhX?=
 =?utf-8?B?SkJWeU9LS2xaRWJDNm5WVUZBbFhHNTRiWG9SM05iSmtTSnBCUTNuY0YyZ092?=
 =?utf-8?B?bWxQblhuUGo1bUUzSkRNUnd4ZDBxNUV6bmhQa2xBL3dwNUc5c1I5aFNKN1lk?=
 =?utf-8?B?YzIvcjBqLytBbmZGV3F6WFQxeldPRFlURHRHWUFvNUNVZ1BkRitOWkxlWGxm?=
 =?utf-8?B?T3cxLzJ0cDNGZy9zRG42YmYxeU9nay83OWF1SlVCcmZsOVY4MnRRclhDcENJ?=
 =?utf-8?B?ZWpsdHJGVHNabUNUR2lzYU1NRXZlKzFwaURTWnVEY1lkYVB6V0g2UEY4Qzkx?=
 =?utf-8?B?QncvYVQ4QzBidW5uSEQzVW00N3pQMTZNMHFvTWtSbVV5MmU4akVscnVXeEhE?=
 =?utf-8?B?TndNeVU4MjIvc0RPY0xodG51MUhBVldqV0o5ZjBDOWRDcEFlNHdiZk5rUHYv?=
 =?utf-8?Q?M4Yw67CmqruOiZU8LagBCgZRh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8985f453-0eb1-47c3-b023-08db1fef96d5
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 16:10:09.3788
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PCju49JkSUFON+Mxqi6zWp0VZUpYWBmVGVnSLYHpmPVFhfZ1RcNZxOSPOEY/NcLbLn/wjmk37RXMhGATUc7Ayg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5315
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+ vc4 maintainers

On 3/8/23 04:34, Qingqing Zhuo wrote:
> [Why]
> drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_bind’:
> drivers/gpu/drm/vc4/vc4_hdmi.c:3448:17: error: label ‘err_disable_runtime_pm’ used but not defined
> 
> [How]
> update err_disable_runtime_pm to err_put_runtime_pm.
> 
> Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
> ---
>   drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 9e145690c480..edf882360d24 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -3445,7 +3445,7 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
>   	 */
>   	ret = pm_runtime_resume_and_get(dev);
>   	if (ret)
> -		goto err_disable_runtime_pm;
> +		goto err_put_runtime_pm;
>   
>   	if ((of_device_is_compatible(dev->of_node, "brcm,bcm2711-hdmi0") ||
>   	     of_device_is_compatible(dev->of_node, "brcm,bcm2711-hdmi1")) &&

-- 
Hamza