Subject: Re: [PATCH 18/28] sfc_ef100: Drop redundant
 pci_disable_pcie_error_reporting()
To:     Bjorn Helgaas <helgaas@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>,
        Martin Habets <habetsm.xilinx@gmail.com>
References: <20230307181940.868828-1-helgaas@kernel.org>
 <20230307181940.868828-19-helgaas@kernel.org>
From:   Edward Cree <ecree.xilinx@gmail.com>
Message-ID: <92c6d8e0-d131-1080-e7ce-fda97cd4a02e@gmail.com>
Date:   Wed, 8 Mar 2023 16:16:45 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20230307181940.868828-19-helgaas@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 07/03/2023 18:19, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> 51b35a454efd ("sfc: skeleton EF100 PF driver") added a call to
> pci_disable_pcie_error_reporting() in ef100_pci_remove().
> 
> Remove this call since there's no apparent reason to disable error
> reporting when it was not previously enabled.
> 
> Note that since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core enables PCIe error reporting for all devices during
> enumeration, so the driver doesn't need to do it itself.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Edward Cree <ecree.xilinx@gmail.com>
> Cc: Martin Habets <habetsm.xilinx@gmail.com>
> ---

Yeah it looks like we meant to add an enable too but lost it somewhere
 in the upstreaming process.  Anyway,
Acked-by: Edward Cree <ecree.xilinx@gmail.com>