Feedback-ID: i8771445c:Fastmail
Date:   Wed, 8 Mar 2023 17:19:45 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Hamza Mahfooz <hamza.mahfooz@amd.com>
Cc:     Qingqing Zhuo <qingqing.zhuo@amd.com>,
        amd-gfx@lists.freedesktop.org, Emma Anholt <emma@anholt.net>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/vc4: Fix build error with undefined label
Message-ID: <20230308161945.svooztnablyvm75e@houat>
References: <20230308093408.239331-1-qingqing.zhuo@amd.com>
 <ac8fed53-6f05-6ec7-9ef5-61110cd83c0b@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <ac8fed53-6f05-6ec7-9ef5-61110cd83c0b@amd.com>
Precedence: bulk

Hi,

On Wed, Mar 08, 2023 at 11:11:22AM -0500, Hamza Mahfooz wrote:
> + vc4 maintainers
>=20
> On 3/8/23 04:34, Qingqing Zhuo wrote:
> > [Why]
> > drivers/gpu/drm/vc4/vc4_hdmi.c: In function =E2=80=98vc4_hdmi_bind=E2=
=80=99:
> > drivers/gpu/drm/vc4/vc4_hdmi.c:3448:17: error: label =E2=80=98err_disab=
le_runtime_pm=E2=80=99 used but not defined
> >=20
> > [How]
> > update err_disable_runtime_pm to err_put_runtime_pm.
> >=20
> > Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
> > ---
> >   drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_h=
dmi.c
> > index 9e145690c480..edf882360d24 100644
> > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> > @@ -3445,7 +3445,7 @@ static int vc4_hdmi_bind(struct device *dev, stru=
ct device *master, void *data)
> >   	 */
> >   	ret =3D pm_runtime_resume_and_get(dev);
> >   	if (ret)
> > -		goto err_disable_runtime_pm;
> > +		goto err_put_runtime_pm;
> >   	if ((of_device_is_compatible(dev->of_node, "brcm,bcm2711-hdmi0") ||
> >   	     of_device_is_compatible(dev->of_node, "brcm,bcm2711-hdmi1")) &&

The current drm-misc-next branch doesn't have that context at all. What
tree is this based on?

Maxime