Feedback-ID: i8771445c:Fastmail
Date:   Wed, 8 Mar 2023 17:32:48 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     "Zhuo, Qingqing (Lillian)" <Qingqing.Zhuo@amd.com>
Cc:     "Mahfooz, Hamza" <Hamza.Mahfooz@amd.com>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        Emma Anholt <emma@anholt.net>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/vc4: Fix build error with undefined label
Message-ID: <20230308163248.u7rvtadhlre3yua5@houat>
References: <20230308093408.239331-1-qingqing.zhuo@amd.com>
 <ac8fed53-6f05-6ec7-9ef5-61110cd83c0b@amd.com>
 <20230308161945.svooztnablyvm75e@houat>
 <PH7PR12MB58315E9E7362E8A750393B6FFBB49@PH7PR12MB5831.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qkfsks6ei5ns2qea"
Content-Disposition: inline
In-Reply-To: <PH7PR12MB58315E9E7362E8A750393B6FFBB49@PH7PR12MB5831.namprd12.prod.outlook.com>
Precedence: bulk


--qkfsks6ei5ns2qea
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 08, 2023 at 04:27:01PM +0000, Zhuo, Qingqing (Lillian) wrote:
> [AMD Official Use Only - General]
>=20
> > Hi,
>=20
> On Wed, Mar 08, 2023 at 11:11:22AM -0500, Hamza Mahfooz wrote:
> > + vc4 maintainers
> >=20
> > On 3/8/23 04:34, Qingqing Zhuo wrote:
> > > [Why]
> > > drivers/gpu/drm/vc4/vc4_hdmi.c: In function =E2=80=98vc4_hdmi_bind=E2=
=80=99:
> > > drivers/gpu/drm/vc4/vc4_hdmi.c:3448:17: error: label=20
> > > =E2=80=98err_disable_runtime_pm=E2=80=99 used but not defined
> > >=20
> > > [How]
> > > update err_disable_runtime_pm to err_put_runtime_pm.
> > >=20
> > > Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
> > > ---
> > >   drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >=20
> > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c=20
> > > b/drivers/gpu/drm/vc4/vc4_hdmi.c index 9e145690c480..edf882360d24=20
> > > 100644
> > > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> > > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> > > @@ -3445,7 +3445,7 @@ static int vc4_hdmi_bind(struct device *dev, st=
ruct device *master, void *data)
> > >   	 */
> > >   	ret =3D pm_runtime_resume_and_get(dev);
> > >   	if (ret)
> > > -		goto err_disable_runtime_pm;
> > > +		goto err_put_runtime_pm;
> > >   	if ((of_device_is_compatible(dev->of_node, "brcm,bcm2711-hdmi0") ||
> > >   	     of_device_is_compatible(dev->of_node, "brcm,bcm2711-hdmi1"))=
=20
> > > &&
>=20
> > The current drm-misc-next branch doesn't have that context at all. What=
 tree is this based on?
>
> This is for amd-staging-drm-next.

I don't get it, why is there a vc4 patch in an AMD tree?

Maxime

--qkfsks6ei5ns2qea
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZAi4sAAKCRDj7w1vZxhR
xd/AAPkB71ZVlsaXmgv3N3XxGXAM/abwFnF9JhIQpClvj3P3tQD+PAA8Fex7MXhD
LEtOEcSBvngbEbYBl+1r0wpj7wBATA8=
=zOVq
-----END PGP SIGNATURE-----

--qkfsks6ei5ns2qea--