Date:   Wed, 8 Mar 2023 11:51:04 -0500
From:   Peter Xu <peterx@redhat.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Paul Gofman <pgofman@codeweavers.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 1/2] mm/uffd: UFFD_FEATURE_WP_UNPOPULATED
Message-ID: <ZAi8+PCsIzExWPQN@x1n>
References: <20230306213925.617814-1-peterx@redhat.com>
 <20230306213925.617814-2-peterx@redhat.com>
 <94be7b9f-c33e-c6dc-4132-6cb78f7c0624@redhat.com>
 <ZAiqPU0RX3JfDFRP@x1n>
 <83b3f3ad-19a2-3737-77dd-3c3f9db82194@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <83b3f3ad-19a2-3737-77dd-3c3f9db82194@redhat.com>
Precedence: bulk

On Wed, Mar 08, 2023 at 04:57:55PM +0100, David Hildenbrand wrote:
> Oh, my thinking was that with markers you postpone placing the shared
> zeropage. So the next read access will require a pagefault to map the shared
> zeropage. Your v1 would have performed best in that case I guess.

Ah, so I misunderstood because the sentence being quote was in another
context I think..

Pagemap may bring overhead constantly though, not sure when vs page faults.
May relevant to num of missing pages.

It's just that we may still want pte markers to avoid losing MISSING+WP
(with WP_UNPOPULATED) use case, which you rightfully pointed out before.

-- 
Peter Xu