Date:   Wed, 8 Mar 2023 18:40:09 +0100
From:   Michal Hocko <mhocko@suse.com>
To:     Yue Zhao <findns94@gmail.com>
Cc:     akpm@linux-foundation.org, roman.gushchin@linux.dev,
        hannes@cmpxchg.org, shakeelb@google.com, muchun.song@linux.dev,
        willy@infradead.org, linux-mm@kvack.org, cgroups@vger.kernel.org,
        linux-kernel@vger.kernel.org, tangyeechou@gmail.com
Subject: Re: [PATCH v3, 0/4] mm, memcg: cgroup v1 and v2 tunable load/store
 tearing fixes
Message-ID: <ZAjIeTBKteZaYEEb@dhcp22.suse.cz>
References: <20230308162555.14195-1-findns94@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230308162555.14195-1-findns94@gmail.com>
Precedence: bulk

On Thu 09-03-23 00:25:51, Yue Zhao wrote:
> This patch series helps to prevent load/store tearing in
> several cgroup knobs.
> 
> As kindly pointed out by Michal Hocko, we should add 
> [WRITE|READ]_ONCE for all occurrences of memcg->oom_kill_disable,
> memcg->swappiness and memcg->soft_limit.
> 
> v3:
> - Add [WRITE|READ]_ONCE for all occurrences of
> memcg->oom_kill_disable, memcg->swappiness and memcg->soft_limit
> v2:
> - Rephrase changelog
> - Add [WRITE|READ]_ONCE for memcg->oom_kill_disable,
>  memcg->swappiness, vm_swappiness and memcg->soft_limit
> v1:
> - Add [WRITE|READ]_ONCE for memcg->oom_group
> 
> Past patches:
> V2: https://lore.kernel.org/linux-mm/20230306154138.3775-1-findns94@gmail.com/
> V1: https://lore.kernel.org/linux-mm/20230220151638.1371-1-findns94@gmail.com/
> 
> Yue Zhao (4):
>   mm, memcg: Prevent memory.oom.group load/store tearing
>   mm, memcg: Prevent memory.swappiness load/store tearing
>   mm, memcg: Prevent memory.oom_control load/store tearing
>   mm, memcg: Prevent memory.soft_limit_in_bytes load/store tearing
> 
>  include/linux/swap.h |  8 ++++----
>  mm/memcontrol.c      | 30 +++++++++++++++---------------
>  2 files changed, 19 insertions(+), 19 deletions(-)

Acked-by: Michal Hocko <mhocko@suse.com>

Btw. you could have preserved acks for patches you haven't changed from
the previous version.

-- 
Michal Hocko
SUSE Labs