Date:   Wed, 8 Mar 2023 17:43:48 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Danilo Krummrich <dakr@redhat.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Liam R. Howlett" <Liam.Howlett@oracle.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate()
Message-ID: <ZAjJVNOkv/xL6GBC@casper.infradead.org>
References: <20230302011035.4928-1-dakr@redhat.com>
 <20230302015242.xi3y53okc4skmonn@revolver>
 <9abef101-3a9b-0bdd-7139-ced7d5e28ebe@suse.cz>
 <da65d59e-f918-d7d5-644b-33cc51c2ba6c@redhat.com>
 <20230308144343.GA16259@lst.de>
 <59b703ac-9660-a0e5-09f7-c5b69d4f39cb@redhat.com>
 <20230308152913.GA19628@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230308152913.GA19628@lst.de>
Precedence: bulk

On Wed, Mar 08, 2023 at 04:29:13PM +0100, Christoph Hellwig wrote:
> On Wed, Mar 08, 2023 at 04:18:55PM +0100, Danilo Krummrich wrote:
> > Consistency wise I think we should either also export mas_preallocate() or 
> > don't export the other ones either.
> 
> Please send a patch to drop all unused exports.

While that's usually a good rule, it just creates unnecessary friction
in this kind of case -- a set of library functions which have only been
introduced in the last few months.  If they're still unused in a year,
sure, let's get rid of the exports.